Articulate the cancel behavior in WebMouseWheelEvent.

Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
Committed: https://crrev.com/8050a57a2e31012caa7d0521a9be661491f8ef3d
Cr-Commit-Position: refs/heads/master@{#388643}

[dtapuska, 2016-04-19 15:48:43]

Description was changed from

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
==========

to

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
==========

[dtapuska, 2016-04-19 15:48:43]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org, tdresser@chromium.org

[tdresser, 2016-04-20 13:20:11]

LGTM

https://codereview.chromium.org/1894363004/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/1894363004/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:39: // adjusted by the
compositor.
Maybe "since the compositor determined all event listeners are passive."?

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/WheelEvent.h (right):

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/WheelEvent.h:64: bool canScroll, int
resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode, bool
cancelable)
Should the final parameter be a two-valued enum, for better readability?

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:910:
PlatformEvent::CtrlKey, 0, 0, true, -1 /* null plugin id */, true /*
hasPreciseScrollingDeltas */, Event::RailsModeHorizontal, true);
Add comment indicating what this flag indicates.

[dtapuska, 2016-04-20 14:03:04]

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/WheelEvent.h (right):

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/WheelEvent.h:64: bool canScroll, int
resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode, bool
cancelable)
On 2016/04/20 13:20:10, tdresser wrote:
> Should the final parameter be a two-valued enum, for better readability?

I don't disagree with this but the rest of the code is this way. I think there
is potential to clean this up if we define cancelable to be an enum throughout
the DOM events; it would be awkward just to do it on this one event.

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:910:
PlatformEvent::CtrlKey, 0, 0, true, -1 /* null plugin id */, true /*
hasPreciseScrollingDeltas */, Event::RailsModeHorizontal, true);
On 2016/04/20 13:20:10, tdresser wrote:
> Add comment indicating what this flag indicates.

Done.

[dtapuska, 2016-04-20 14:03:23]

https://codereview.chromium.org/1894363004/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/1894363004/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:39: // adjusted by the
compositor.
On 2016/04/20 13:20:10, tdresser wrote:
> Maybe "since the compositor determined all event listeners are passive."?

Done.

[tdresser, 2016-04-20 14:53:26]

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/WheelEvent.h (right):

https://codereview.chromium.org/1894363004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/WheelEvent.h:64: bool canScroll, int
resendingPluginId, bool hasPreciseScrollingDeltas, RailsMode railsMode, bool
cancelable)
On 2016/04/20 14:03:04, dtapuska wrote:
> On 2016/04/20 13:20:10, tdresser wrote:
> > Should the final parameter be a two-valued enum, for better readability?
> 
> I don't disagree with this but the rest of the code is this way. I think there
> is potential to clean this up if we define cancelable to be an enum throughout
> the DOM events; it would be awkward just to do it on this one event.

SGTM.

[Rick Byers, 2016-04-20 15:31:40]

WebKit LGTM

[dtapuska, 2016-04-20 23:04:52]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-04-20 23:04:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1894363004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-20 23:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894363004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894363004/40001

[commit-bot: I haz the power, 2016-04-21 00:44:06]

Description was changed from

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
==========

to

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
==========

[commit-bot: I haz the power, 2016-04-21 00:44:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:29:34]

Description was changed from

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661
==========

to

==========
Articulate the cancel behavior in WebMouseWheelEvent.

Add a DispatchType to mouse wheel events; set the cancelable flag
based on the dispatch type.

This change is similar to the one done for touch events
see https://codereview.chromium.org/1888163003/.

BUG=601661

Committed: https://crrev.com/8050a57a2e31012caa7d0521a9be661491f8ef3d
Cr-Commit-Position: refs/heads/master@{#388643}
==========

[commit-bot: I haz the power, 2016-04-22 19:29:35]

Patchset 3 (id:??) landed as
https://crrev.com/8050a57a2e31012caa7d0521a9be661491f8ef3d
Cr-Commit-Position: refs/heads/master@{#388643}