Remove deprecated global variables in libevent that cause tsan errors.

Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org

Committed: https://crrev.com/7086da4ef5e043e935a86be9849bd9cd60ccecf8
Cr-Commit-Position: refs/heads/master@{#389103}

[tommi (sloooow) - chröme, 2016-04-22 12:02:07]

tommi@chromium.org changed reviewers:
+ mark@chromium.org, tfarina@chromium.org

[tommi (sloooow) - chröme, 2016-04-22 12:02:08]

tfarina: The change log suggests you might be the appropriate reviewer.

mark: Asking you to take a look since you're an owner.

[tommi (sloooow) - chröme, 2016-04-22 12:02:14]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 12:02:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912113002/1

[Mark Mentovai, 2016-04-22 13:02:58]

LGTM

[commit-bot: I haz the power, 2016-04-22 13:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:09:49]

Dry run: This issue passed the CQ dry run.

[tfarina, 2016-04-22 13:46:36]

I'm happy that Mark has looked over this.

With his approval, I'm happy to approve as well.

lgtm

https://codereview.chromium.org/1912113002/diff/1/base/third_party/libevent/c...
File base/third_party/libevent/chromium.patch (right):

https://codereview.chromium.org/1912113002/diff/1/base/third_party/libevent/c...
base/third_party/libevent/chromium.patch:64: /* Prototypes */
Is this comment necessary? I wouldn't add it my self.

[tfarina, 2016-04-22 13:47:17]

Description was changed from

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
==========

to

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org
==========

[tommi (sloooow) - chröme, 2016-04-22 14:34:54]

thanks for the quick review.

https://codereview.chromium.org/1912113002/diff/1/base/third_party/libevent/c...
File base/third_party/libevent/chromium.patch (right):

https://codereview.chromium.org/1912113002/diff/1/base/third_party/libevent/c...
base/third_party/libevent/chromium.patch:64: /* Prototypes */
On 2016/04/22 13:46:35, tfarina wrote:
> Is this comment necessary? I wouldn't add it my self.

It's necessary in this patch file because it's in the original code (I'm not
adding it). It's better to look at actual diff I'm making to the file if you
just look at the event.c diff.

[tommi (sloooow) - chröme, 2016-04-22 14:35:00]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912113002/1

[commit-bot: I haz the power, 2016-04-22 14:43:16]

Description was changed from

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org
==========

to

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org
==========

[commit-bot: I haz the power, 2016-04-22 14:43:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:47:19]

Description was changed from

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org
==========

to

==========
Remove deprecated global variables in libevent that cause tsan errors.

BUG=605894
R=mark@chromium.org,tfarina@chromium.org

Committed: https://crrev.com/7086da4ef5e043e935a86be9849bd9cd60ccecf8
Cr-Commit-Position: refs/heads/master@{#389103}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:20]

Patchset 1 (id:??) landed as
https://crrev.com/7086da4ef5e043e935a86be9849bd9cd60ccecf8
Cr-Commit-Position: refs/heads/master@{#389103}