Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Side by Side Diff: base/third_party/libevent/README.chromium

Issue 1912113002: Remove deprecated global variables in libevent that cause tsan errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 Name: libevent 1 Name: libevent
2 URL: http://libevent.org/ 2 URL: http://libevent.org/
3 Version: 1.4.15 3 Version: 1.4.15
4 License: BSD 4 License: BSD
5 Security Critical: yes 5 Security Critical: yes
6 6
7 Local Modifications: 7 Local Modifications:
8 Rather than use libevent's own build system, we just build a Chrome 8 Rather than use libevent's own build system, we just build a Chrome
9 static library using GYP. 9 static library using GYP.
10 10
11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris, 11 1) Run configure and "make event-config.h" on Linux, FreeBSD, Solaris,
12 and Mac and copy config.h and event-config.h to linux/, freebsd/, 12 and Mac and copy config.h and event-config.h to linux/, freebsd/,
13 solaris/, and mac/ respectively. 13 solaris/, and mac/ respectively.
14 2) Add libevent.gyp. 14 2) Add libevent.gyp.
15 3) chromium.patch is applied to make the following changes: 15 3) chromium.patch is applied to make the following changes:
16 - Allow libevent to be used without being installed by changing <...> 16 - Allow libevent to be used without being installed by changing <...>
17 #includes to "...". 17 #includes to "...".
18 - Fix a race condition in event_del. 18 - Fix a race condition in event_del.
19 - Optimistically assume CLOCK_MONOTONIC is available and fallback if it 19 - Optimistically assume CLOCK_MONOTONIC is available and fallback if it
20 fails, rather than explicitly testing for it. 20 fails, rather than explicitly testing for it.
21 - Remove an unneeded variable that causes a -Werror build failure. 21 - Remove an unneeded variable that causes a -Werror build failure.
22 - Add an #ifndef to fix a preprocessor redefined -Werror build failure. 22 - Add an #ifndef to fix a preprocessor redefined -Werror build failure.
23 - Revert the patch from http://sourceforge.net/p/levent/bugs/223/ that 23 - Revert the patch from http://sourceforge.net/p/levent/bugs/223/ that
24 introduces use-after-free memory corruption when an event callback frees 24 introduces use-after-free memory corruption when an event callback frees
25 the struct event memory. 25 the struct event memory.
26 - Remove deprecated global variables, event_sigcb and event_gotsig
27 (essentially unused) that trigger tsan errors. (crbug/605894)
26 4) The directories WIN32-Code and WIN32-Prj are not included. 28 4) The directories WIN32-Code and WIN32-Prj are not included.
27 5) The configs for android were copied from Linux's which were very close to 29 5) The configs for android were copied from Linux's which were very close to
28 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY. 30 android one with the exception of HAVE_FD_MASK and HAVE_STRLCPY.
29 6) Add files to support building with the PNaCl toolchain. Added 31 6) Add files to support building with the PNaCl toolchain. Added
30 libevent_nacl_nonsfi.gyp for build rule. nacl_nonsfi/config.h and 32 libevent_nacl_nonsfi.gyp for build rule. nacl_nonsfi/config.h and
31 nacl_nonsfi/event-config.h are derived from linux/ counterparts. 33 nacl_nonsfi/event-config.h are derived from linux/ counterparts.
32 nacl_nonsfi/random.c is also added to provide the random() function, 34 nacl_nonsfi/random.c is also added to provide the random() function,
33 which is missing in the newlib-based PNaCl toolchain. 35 which is missing in the newlib-based PNaCl toolchain.
34 7) Stub out signal.c for nacl_helper_nonsfi. socketpair() will be prohibited 36 7) Stub out signal.c for nacl_helper_nonsfi. socketpair() will be prohibited
35 by sandbox in nacl_helper_nonsfi. 37 by sandbox in nacl_helper_nonsfi.
OLDNEW
« no previous file with comments | « no previous file | base/third_party/libevent/chromium.patch » ('j') | base/third_party/libevent/chromium.patch » ('J')

Powered by Google App Engine
This is Rietveld 408576698