Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1912093002: Require that heap collections are used over traceable elements. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require that heap collections are used over traceable elements. While it is fully supported, having Blink GC heap collection objects with elements not themselves being heap objects nor containing references to such, is unnecessary. And arguably a sign that the code is unintentionally using a heap collection. Thus, add static_assert()s which prevent heap collections containing no traceable references. R=haraken BUG=585328 Committed: https://crrev.com/334dbe1a064d529de2be7ef984fefc575c3d1d3a Cr-Commit-Position: refs/heads/master@{#389435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -95 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 6 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 5 chunks +11 lines, -41 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sof
Just tabling this one for discussion & consideration -- I think we need to clarify ...
4 years, 8 months ago (2016-04-22 09:51:12 UTC) #2
haraken
LGTM Limiting on-heap collections to only traceable elements sounds like a reasonable rule.
4 years, 8 months ago (2016-04-22 18:10:28 UTC) #3
sof
On 2016/04/22 18:10:28, haraken wrote: > LGTM > > Limiting on-heap collections to only traceable ...
4 years, 8 months ago (2016-04-23 08:10:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912093002/1
4 years, 8 months ago (2016-04-25 06:48:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 08:18:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912093002/1
4 years, 8 months ago (2016-04-25 09:08:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 09:12:29 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 09:13:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/334dbe1a064d529de2be7ef984fefc575c3d1d3a
Cr-Commit-Position: refs/heads/master@{#389435}

Powered by Google App Engine
This is Rietveld 408576698