Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp

Issue 1912093002: Require that heap collections are used over traceable elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/HeapAllocator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
index e4ac84cef94c78560568c2eb1b3e4c183cc6ca61..79d85a208ce1634343da213d8583323c358d5616 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
@@ -224,58 +224,6 @@ TEST_F(ToV8Test, heapVector)
TEST_TOV8("hoge,fuga,", v);
}
-TEST_F(ToV8Test, stringHeapVectors)
-{
- HeapVector<String> stringVector;
- stringVector.append("foo");
- stringVector.append("bar");
- TEST_TOV8("foo,bar", stringVector);
-
- HeapVector<AtomicString> atomicStringVector;
- atomicStringVector.append("quux");
- atomicStringVector.append("bar");
- TEST_TOV8("quux,bar", atomicStringVector);
-}
-
-TEST_F(ToV8Test, basicTypeHeapVectors)
-{
- HeapVector<int> intVector;
- intVector.append(42);
- intVector.append(23);
- TEST_TOV8("42,23", intVector);
-
- HeapVector<long> longVector;
- longVector.append(31773);
- longVector.append(404);
- TEST_TOV8("31773,404", longVector);
-
- HeapVector<unsigned> unsignedVector;
- unsignedVector.append(1);
- unsignedVector.append(2);
- TEST_TOV8("1,2", unsignedVector);
-
- HeapVector<unsigned long> unsignedLongVector;
- unsignedLongVector.append(1001);
- unsignedLongVector.append(2002);
- TEST_TOV8("1001,2002", unsignedLongVector);
-
- HeapVector<float> floatVector;
- floatVector.append(0.125);
- floatVector.append(1.);
- TEST_TOV8("0.125,1", floatVector);
-
- HeapVector<double> doubleVector;
- doubleVector.append(2.3);
- doubleVector.append(4.2);
- TEST_TOV8("2.3,4.2", doubleVector);
-
- HeapVector<bool> boolVector;
- boolVector.append(true);
- boolVector.append(true);
- boolVector.append(false);
- TEST_TOV8("true,true,false", boolVector);
-}
-
TEST_F(ToV8Test, withScriptState)
{
ScriptValue value(m_scope.getScriptState(), v8::Number::New(m_scope.isolate(), 1234.0));
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/HeapAllocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698