Use the new legacyCreateTypeface that has an SkFontStyle parameter

third_party/WebKit/Source/platform/fonts/FontDescription.cpp

Index: third_party/WebKit/Source/platform/fonts/FontDescription.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontDescription.cpp b/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
index cde54996f91e78b47033a4320ff8b9765813cfd4..5a53af31f8ec65893f54f1e0d59fe6b36824faf2 100644
--- a/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
@@ -281,7 +281,8 @@ unsigned FontDescription::styleHashWithoutFamilyList() const
 SkFontStyle FontDescription::skiaFontStyle() const
 {
     int width = static_cast<int>(stretch());
-    SkFontStyle::Slant slant = style() == FontStyleItalic
+    // FIXME: handle oblique styles when they're supported in skia

[bungeman-skia, 2016/04/27 20:42:14]

So Skia now has an SkFontStyle::kOblique_Slant. I created a cl to update this
code here to us it, see https::/crrev.com/1921503006/ . On Windows this changes
the four layout tests that actually ask for oblique, but unfortunately the
rebaseline bot / NeedsRebaseline is currently disabled, making things difficult.

[Tom (Use chromium acct), 2016/04/28 17:49:20]

Acknowledged.

+    SkFontStyle::Slant slant = style()
         ? SkFontStyle::kItalic_Slant
         : SkFontStyle::kUpright_Slant;
     return SkFontStyle(numericFontWeight(weight()), width, slant);