Use the new legacyCreateTypeface that has an SkFontStyle parameter

third_party/WebKit/Source/platform/fonts/FontDescription.cpp

 /*
  * Copyright (C) 2007 Nicholas Shanks <contact@nickshanks.com>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 263 matching lines @@
     addFloatToHash(hash, m_wordSpacing);
     addToHash(hash, m_fieldsAsUnsigned[0]);
     addToHash(hash, m_fieldsAsUnsigned[1]);
 
     return hash;
 }
 
 SkFontStyle FontDescription::skiaFontStyle() const
 {
     int width = static_cast<int>(stretch());
-    SkFontStyle::Slant slant = style() == FontStyleItalic
+    // FIXME: handle oblique styles when they're supported in skia

[bungeman-skia, 2016/04/27 20:42:14]

So Skia now has an SkFontStyle::kOblique_Slant. I created a cl to update this
code here to us it, see https::/crrev.com/1921503006/ . On Windows this changes
the four layout tests that actually ask for oblique, but unfortunately the
rebaseline bot / NeedsRebaseline is currently disabled, making things difficult.

[Tom (Use chromium acct), 2016/04/28 17:49:20]

Acknowledged.

+    SkFontStyle::Slant slant = style()
         ? SkFontStyle::kItalic_Slant
         : SkFontStyle::kUpright_Slant;
     return SkFontStyle(numericFontWeight(weight()), width, slant);
     static_assert(
         static_cast<int>(FontStretchUltraCondensed) == static_cast<int>(SkFontStyle::kUltraCondensed_Width),
         "FontStretchUltraCondensed should map to kUltraCondensed_Width");
     static_assert(
         static_cast<int>(FontStretchNormal) == static_cast<int>(SkFontStyle::kNormal_Width),
         "FontStretchNormal should map to kNormal_Width");
     static_assert(
         static_cast<int>(FontStretchUltraExpanded) == static_cast<int>(SkFontStyle::kUltaExpanded_Width),
         "FontStretchUltraExpanded should map to kUltaExpanded_Width");
 }
 
 } // namespace blink