Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the

Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )

Reason for revert:
WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115

Original issue's description:
> Add code to call skia's matchFamilyStyleCharacter API
>
> Add code to call skia's matchFamilyStyleCharacter API, which uses the
> DirectWrite font fallback to find fonts for characters that do not exist
> in the default font. The FontCache and FontDescription changes are
> refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
> The FontCacheSkiaWin change adds logic to call skia's
> matchFamilyStyleCharacter API, which will ultimately call into
> DirectWrite.
>
> This is part 3 of a three part change.
> 1: https://codereview.chromium.org/1878843002/
>    Adds support for specifying a font fallback in skia
> 2: https://codereview.chromium.org/1846433005/
>    Implements the fallback proxy in Chromium
> 3: https://codereview.chromium.org/1883483002/
>    Adds code to blink to call skia's fallback API
>
> BUG=459056
>
> patch from issue 1740593002 at patchset 140001 (http://crrev.com/1740593002#ps140001)

TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,kulshin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459056
Committed: https://crrev.com/6485a0d3465ba3b0bcca6385f8740a5c2e7c0138
Cr-Commit-Position: refs/heads/master@{#388893}

[apacible, 2016-04-21 20:53:00]

Created Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the

[commit-bot: I haz the power, 2016-04-21 20:53:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911863002/1

[commit-bot: I haz the power, 2016-04-21 20:55:00]

Description was changed from

==========
Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )

Reason for revert:
WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115

Original issue's description:
> Add code to call skia's matchFamilyStyleCharacter API
> 
> Add code to call skia's matchFamilyStyleCharacter API, which uses the
> DirectWrite font fallback to find fonts for characters that do not exist
> in the default font. The FontCache and FontDescription changes are
> refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
> The FontCacheSkiaWin change adds logic to call skia's
> matchFamilyStyleCharacter API, which will ultimately call into
> DirectWrite.
> 
> This is part 3 of a three part change.
> 1: https://codereview.chromium.org/1878843002/
>    Adds support for specifying a font fallback in skia
> 2: https://codereview.chromium.org/1846433005/
>    Implements the fallback proxy in Chromium
> 3: https://codereview.chromium.org/1883483002/
>    Adds code to blink to call skia's fallback API
> 
> BUG=459056
> 
> patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)

TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459056
==========

to

==========
Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )

Reason for revert:
WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115

Original issue's description:
> Add code to call skia's matchFamilyStyleCharacter API
> 
> Add code to call skia's matchFamilyStyleCharacter API, which uses the
> DirectWrite font fallback to find fonts for characters that do not exist
> in the default font. The FontCache and FontDescription changes are
> refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
> The FontCacheSkiaWin change adds logic to call skia's
> matchFamilyStyleCharacter API, which will ultimately call into
> DirectWrite.
> 
> This is part 3 of a three part change.
> 1: https://codereview.chromium.org/1878843002/
>    Adds support for specifying a font fallback in skia
> 2: https://codereview.chromium.org/1846433005/
>    Implements the fallback proxy in Chromium
> 3: https://codereview.chromium.org/1883483002/
>    Adds code to blink to call skia's fallback API
> 
> BUG=459056
> 
> patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)

TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459056
==========

[commit-bot: I haz the power, 2016-04-21 20:55:01]

Committed patchset #1 (id:1)

[eae, 2016-04-21 20:55:36]

Actual results are better (more correct) than the expected, I'd argue we should
rebaseline the tests rather than revert the change.

[Ilya Kulshin, 2016-04-21 21:11:21]

On 2016/04/21 20:55:36, eae wrote:
> Actual results are better (more correct) than the expected, I'd argue we
should
> rebaseline the tests rather than revert the change.

Agree on rebaselining fast/text/decorations-with-text-combine.html
Don't really have an opinion on fast/encoding/invalid-UTF-8.html - it's just
rendering a slightly different invalid character glyph.
Still investigating
inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html - that one
might actually be a regression; not sure yet.

[Ilya Kulshin, 2016-04-21 21:25:02]

On 2016/04/21 21:11:21, Ilya Kulshin wrote:
> On 2016/04/21 20:55:36, eae wrote:
> > Actual results are better (more correct) than the expected, I'd argue we
> should
> > rebaseline the tests rather than revert the change.
> 
> Agree on rebaselining fast/text/decorations-with-text-combine.html
> Don't really have an opinion on fast/encoding/invalid-UTF-8.html - it's just
> rendering a slightly different invalid character glyph.
> Still investigating
> inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html - that one
> might actually be a regression; not sure yet.

confirmed that inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html
is not a regression. "Segoe UI Historic" is the correct font that can render
hieroglyphs on Win10.

[apacible, 2016-04-21 21:27:03]

On 2016/04/21 21:25:02, Ilya Kulshin wrote:
> On 2016/04/21 21:11:21, Ilya Kulshin wrote:
> > On 2016/04/21 20:55:36, eae wrote:
> > > Actual results are better (more correct) than the expected, I'd argue we
> > should
> > > rebaseline the tests rather than revert the change.
> > 
> > Agree on rebaselining fast/text/decorations-with-text-combine.html
> > Don't really have an opinion on fast/encoding/invalid-UTF-8.html - it's just
> > rendering a slightly different invalid character glyph.
> > Still investigating
> > inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html - that one
> > might actually be a regression; not sure yet.
> 
> confirmed that
inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html
> is not a regression. "Segoe UI Historic" is the correct font that can render
> hieroglyphs on Win10.

Rebaselining sounds good. Thanks for investigating!

[commit-bot: I haz the power, 2016-04-22 19:39:15]

Description was changed from

==========
Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )

Reason for revert:
WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115

Original issue's description:
> Add code to call skia's matchFamilyStyleCharacter API
> 
> Add code to call skia's matchFamilyStyleCharacter API, which uses the
> DirectWrite font fallback to find fonts for characters that do not exist
> in the default font. The FontCache and FontDescription changes are
> refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
> The FontCacheSkiaWin change adds logic to call skia's
> matchFamilyStyleCharacter API, which will ultimately call into
> DirectWrite.
> 
> This is part 3 of a three part change.
> 1: https://codereview.chromium.org/1878843002/
>    Adds support for specifying a font fallback in skia
> 2: https://codereview.chromium.org/1846433005/
>    Implements the fallback proxy in Chromium
> 3: https://codereview.chromium.org/1883483002/
>    Adds code to blink to call skia's fallback API
> 
> BUG=459056
> 
> patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)

TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459056
==========

to

==========
Revert of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )

Reason for revert:
WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115

Original issue's description:
> Add code to call skia's matchFamilyStyleCharacter API
>
> Add code to call skia's matchFamilyStyleCharacter API, which uses the
> DirectWrite font fallback to find fonts for characters that do not exist
> in the default font. The FontCache and FontDescription changes are
> refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
> The FontCacheSkiaWin change adds logic to call skia's
> matchFamilyStyleCharacter API, which will ultimately call into
> DirectWrite.
>
> This is part 3 of a three part change.
> 1: https://codereview.chromium.org/1878843002/
>    Adds support for specifying a font fallback in skia
> 2: https://codereview.chromium.org/1846433005/
>    Implements the fallback proxy in Chromium
> 3: https://codereview.chromium.org/1883483002/
>    Adds code to blink to call skia's fallback API
>
> BUG=459056
>
> patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)

TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459056

Committed: https://crrev.com/6485a0d3465ba3b0bcca6385f8740a5c2e7c0138
Cr-Commit-Position: refs/heads/master@{#388893}
==========

[commit-bot: I haz the power, 2016-04-22 19:39:16]

Patchset 1 (id:??) landed as
https://crrev.com/6485a0d3465ba3b0bcca6385f8740a5c2e7c0138
Cr-Commit-Position: refs/heads/master@{#388893}