Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1911833002: Converts DockedWindowLayoutManager to use WmRootWindowControllerObserver (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts DockedWindowLayoutManager to use WmRootWindowControllerObserver And removes the last bit of aura and shell it was using. BUG=603369 TEST=covered by tests R=varkha@chromium.org Committed: https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540 Cr-Commit-Position: refs/heads/master@{#389141}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -50 lines) Patch
M ash/ash.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.h View 3 chunks +13 lines, -1 line 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.cc View 3 chunks +40 lines, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/common/wm_root_window_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
A ash/wm/common/wm_root_window_controller_observer.h View 1 chunk +28 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 6 chunks +13 lines, -19 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 8 chunks +11 lines, -29 lines 0 comments Download

Dependent Patchsets:

Issue 1913473002 Patch 1

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-21 19:54:17 UTC) #1
varkha
lgtm
4 years, 8 months ago (2016-04-22 16:39:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911833002/20001
4 years, 8 months ago (2016-04-22 16:41:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 16:51:11 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:50 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540
Cr-Commit-Position: refs/heads/master@{#389141}

Powered by Google App Engine
This is Rietveld 408576698