🐭 Skip the .pydeps presubmit check on windows

Skip the .pydeps presubmit check on windows

BUG=600604
Committed: https://crrev.com/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81
Cr-Commit-Position: refs/heads/master@{#389109}

[agrieve, 2016-04-21 17:40:56]

agrieve@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-04-22 12:32:08]

phajdan.jr@chromium.org changed reviewers:
+ maruel@chromium.org

[Paweł Hajdan Jr., 2016-04-22 12:32:08]

From the bug it seems it's related to swarming.

The check doesn't seem to be OS-specific. Why don't we fix it on Windows? Could
you elaborate what would it take to do so, or what the obstacles are?

[agrieve, 2016-04-22 13:46:27]

On 2016/04/22 12:32:08, Paweł Hajdan Jr. wrote:
> From the bug it seems it's related to swarming.
> 
> The check doesn't seem to be OS-specific. Why don't we fix it on Windows?
Could
> you elaborate what would it take to do so, or what the obstacles are?

It certainly is fixable, but the obstacles are:
- When I logged into a windows bot and ran "git cl presubmit -u", it failed with
a git error. Not sure how to test this?
- The .pydeps files store paths using /s. To process this in the PRESUBMIT, I'd
want access to "import posixpath". I don't thing the input_api has this?
  a) it's needed for seeing if a changed file is in the list of files
  b) it's needed to properly print out the command that needs to be run to
regenerate

For now, the only platform that uses .pydeps for swarming is Android (for it's
test_runner.py). So, I figured it might not be worth figuring out these things.

[M-A Ruel, 2016-04-22 13:49:50]

On 2016/04/22 13:46:27, agrieve wrote:
> For now, the only platform that uses .pydeps for swarming is Android (for it's
> test_runner.py). So, I figured it might not be worth figuring out these
things.

I agree. lgtm

[Paweł Hajdan Jr., 2016-04-22 14:24:33]

LGTM

[agrieve, 2016-04-22 14:30:38]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:30:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911813002/1

[commit-bot: I haz the power, 2016-04-22 15:13:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:47:35]

Description was changed from

==========
Skip the .pydeps presubmit check on windows

BUG=600604
==========

to

==========
Skip the .pydeps presubmit check on windows

BUG=600604

Committed: https://crrev.com/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81
Cr-Commit-Position: refs/heads/master@{#389109}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:35]

Patchset 1 (id:??) landed as
https://crrev.com/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81
Cr-Commit-Position: refs/heads/master@{#389109}