Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: PRESUBMIT.py

Issue 1911813002: 🐭 Skip the .pydeps presubmit check on windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test_mocks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4421f2ed740039d89fe6465ef67e340e6e6aa49c..c6f80de29f247bc90dae415ad65c7289252c0a14 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1601,6 +1601,10 @@ class PydepsChecker(object):
def _CheckPydepsNeedsUpdating(input_api, output_api, checker_for_tests=None):
"""Checks if a .pydeps file needs to be regenerated."""
+ # This check is mainly for Android, and involves paths not only in the
+ # PRESUBMIT.py, but also in the .pydeps files. Just skip it for Windows.
+ if input_api.platform == 'win32':
+ return []
# TODO(agrieve): Update when there's a better way to detect this: crbug/570091
is_android = input_api.os_path.exists('third_party/android_tools')
pydeps_files = _ALL_PYDEPS_FILES if is_android else _GENERIC_PYDEPS_FILES
« no previous file with comments | « no previous file | PRESUBMIT_test_mocks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698