Issue 1911803004: Code Completion refactoring, follow up on comment in https://codereview.chromium.org/1908703002/ to…

Issue 1911803004: Code Completion refactoring, follow up on comment in https://codereview.chromium.org/1908703002/ to… (Closed)

Created:
4 years, 8 months ago by jwren

Modified:
4 years, 8 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Code Completion refactoring, follow up on comment in https://codereview.chromium.org/1908703002/ to cleanup boilerplate. Also, changed all filters to use one typedef making the all function filters consistent and type checked. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/9c1c7ed25005237c1547f1d591f3d802fabef9e5

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -47 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart	View		1 chunk	+8 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/optype.dart	View	1	8 chunks	+47 lines, -27 lines	0 comments	Download

Total messages: 5 (2 generated)

jwren

4 years, 8 months ago (2016-04-21 19:19:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
9c1c7ed25005237c1547f1d591f3d802fabef9e5 (presubmit successful).