Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1911733002: Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. Starting with https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/53656 these tests became flaky: DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleNotFound BUG=605432 TBR=nyquist@chromium.org Committed: https://crrev.com/620c8a6cf23eebb0497ff4e64216fdaa8818433a Cr-Commit-Position: refs/heads/master@{#388722}

Patch Set 1 #

Patch Set 2 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_chromium
4 years, 8 months ago (2016-04-21 07:24:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911733002/1
4 years, 8 months ago (2016-04-21 07:24:14 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/200422) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 07:36:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911733002/20001
4 years, 8 months ago (2016-04-21 08:02:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 08:37:33 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/620c8a6cf23eebb0497ff4e64216fdaa8818433a Cr-Commit-Position: refs/heads/master@{#388722}
4 years, 8 months ago (2016-04-22 19:32:41 UTC) #10
mdjones
4 years, 7 months ago (2016-05-11 23:44:45 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1969993002/ by mdjones@chromium.org.

The reason for reverting is: A change landed that fixes the reason these became
flaky (https://codereview.chromium.org/1920563002/)..

Powered by Google App Engine
This is Rietveld 408576698