Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6254)

Unified Diff: chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc

Issue 1911733002: Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
diff --git a/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc b/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
index f67d5c641b32014abd8fea6f873d3a0fa515c2a0..67a0372a511814c5379d5015ff3561a3f2d5c707 100644
--- a/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
+++ b/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
@@ -169,8 +169,14 @@ MockDistillerFactory* DomDistillerViewerSourceBrowserTest::distiller_factory_ =
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when the article exists in the database.
+// Flaky on Linux Debug, see http://crbug.com/605432.
+#if defined(OS_LINUX) && !defined(NDEBUG)
+#define MAYBE_NoWebUIBindingsArticleExists DISABLED_NoWebUIBindingsArticleExists
+#else
+#define MAYBE_NoWebUIBindingsArticleExists NoWebUIBindingsArticleExists
+#endif
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
- NoWebUIBindingsArticleExists) {
+ MAYBE_NoWebUIBindingsArticleExists) {
// Ensure there is one item in the database, which will trigger distillation.
const ArticleEntry entry = CreateEntry("DISTILLED", "http://example.com/1");
AddEntry(entry, database_model_);
@@ -183,8 +189,14 @@ IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
// The DomDistillerViewerSource renders untrusted content, so ensure no bindings
// are enabled when the article is not found.
+// Flaky on Linux Debug, see http://crbug.com/605432.
+#if defined(OS_LINUX) && !defined(NDEBUG)
+#define MAYBE_NoWebUIBindingsArticleNotFound DISABLED_NoWebUIBindingsArticleNotFound
+#else
+#define MAYBE_NoWebUIBindingsArticleNotFound NoWebUIBindingsArticleNotFound
+#endif
IN_PROC_BROWSER_TEST_F(DomDistillerViewerSourceBrowserTest,
- NoWebUIBindingsArticleNotFound) {
+ MAYBE_NoWebUIBindingsArticleNotFound) {
// The article does not exist, so assume no distillation will happen.
expect_distillation_ = false;
expect_distiller_page_ = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698