IndexedDB: Coding conventions and cleanup

IndexedDB: Coding conventions and cleanup

Various nits, no behavior change:
* Drop trivial Foo::Create() static methods for refcounted types ported from Blink.
* Remove WebKit:: prefixes where we have using statements
* Remove some useless use of copy constructors where there used to be a type conversion.
* Apply clang-format here and there.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211553

[jsbell, 2013-07-13 00:18:31]

Please take a look?

https://codereview.chromium.org/19117005/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/19117005/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_database.cc:456:
scoped_refptr<IndexedDBDatabase> IndexedDBDatabase::Create(
I did not touch this Create() static method because...

https://codereview.chromium.org/19117005/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_database.cc:463: if
(!backend->OpenInternal())
... of this test which, which causes the Create() to return null. The idiom here
is usually x = new foo(); if (!x->init()) { ... } but I wanted to save that for
another CL.

https://codereview.chromium.org/19117005/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_transaction.cc (left):

https://codereview.chromium.org/19117005/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_transaction.cc:59: std::set<int64>
object_store_hash_set;
This vector -> set conversion is replaced at the call site in
IndexedDBDatabase::CreateTransaction with: set(vec.begin(), vec.end()).

[dgrogan, 2013-07-13 00:29:37]

lgtm

[commit-bot: I haz the power, 2013-07-13 00:30:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/19117005/1

[commit-bot: I haz the power, 2013-07-13 04:54:13]

Change committed as 211553