IndexedDB: Coding conventions and cleanup

content/browser/indexed_db/indexed_db_callbacks.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 13 matching lines @@
 class IndexedDBConnection;
 class IndexedDBCursor;
 class IndexedDBDatabase;
 class IndexedDBDatabaseCallbacks;
 struct IndexedDBDatabaseMetadata;
 
 class CONTENT_EXPORT IndexedDBCallbacks
     : public base::RefCounted<IndexedDBCallbacks> {
  public:
   // Simple payload responses
-  static scoped_refptr<IndexedDBCallbacks> Create(
-      IndexedDBDispatcherHost* dispatcher_host,
-      int32 ipc_thread_id,
-      int32 ipc_callbacks_id) {
-    return make_scoped_refptr(new IndexedDBCallbacks(
-        dispatcher_host, ipc_thread_id, ipc_callbacks_id));
-  }
+  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+                     int32 ipc_thread_id,
+                     int32 ipc_callbacks_id);
 
   // IndexedDBCursor responses
-  static scoped_refptr<IndexedDBCallbacks> Create(
-      IndexedDBDispatcherHost* dispatcher_host,
-      int32 ipc_thread_id,
-      int32 ipc_callbacks_id,
-      int32 ipc_cursor_id) {
-    return make_scoped_refptr(new IndexedDBCallbacks(
-        dispatcher_host, ipc_thread_id, ipc_callbacks_id, ipc_cursor_id));
-  }
+  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+                     int32 ipc_thread_id,
+                     int32 ipc_callbacks_id,
+                     int32 ipc_cursor_id);
+
   // IndexedDBDatabase responses
-  static scoped_refptr<IndexedDBCallbacks> Create(
-      IndexedDBDispatcherHost* dispatcher_host,
-      int32 ipc_thread_id,
-      int32 ipc_callbacks_id,
-      int32 ipc_database_callbacks_id,
-      int64 host_transaction_id,
-      const GURL& origin_url) {
-    return make_scoped_refptr(new IndexedDBCallbacks(dispatcher_host,
-                                                     ipc_thread_id,
-                                                     ipc_callbacks_id,
-                                                     ipc_database_callbacks_id,
-                                                     host_transaction_id,
-                                                     origin_url));
-  }
+  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
+                     int32 ipc_thread_id,
+                     int32 ipc_callbacks_id,
+                     int32 ipc_database_callbacks_id,
+                     int64 host_transaction_id,
+                     const GURL& origin_url);
 
   virtual void OnError(const IndexedDBDatabaseError& error);
 
   // IndexedDBFactory::GetDatabaseNames
   virtual void OnSuccess(const std::vector<string16>& string);
 
   // IndexedDBFactory::Open / DeleteDatabase
   virtual void OnBlocked(int64 existing_version);
 
   // IndexedDBFactory::Open
@@ skipping 36 matching lines @@
   // IndexedDBDatabase::Count
   virtual void OnSuccess(int64 value);
 
   // IndexedDBDatabase::Delete
   // IndexedDBCursor::Continue / Advance (when complete)
   virtual void OnSuccess();
 
  protected:
   virtual ~IndexedDBCallbacks();
 
-  // Simple payload responses
-  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
-                     int32 ipc_thread_id,
-                     int32 ipc_callbacks_id);
-
-  // IndexedDBCursor responses
-  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
-                     int32 ipc_thread_id,
-                     int32 ipc_callbacks_id,
-                     int32 ipc_cursor_id);
-
-  // IndexedDBDatabase responses
-  IndexedDBCallbacks(IndexedDBDispatcherHost* dispatcher_host,
-                     int32 ipc_thread_id,
-                     int32 ipc_callbacks_id,
-                     int32 ipc_database_callbacks_id,
-                     int64 host_transaction_id,
-                     const GURL& origin_url);
-
  private:
   friend class base::RefCounted<IndexedDBCallbacks>;
 
   // Originally from IndexedDBCallbacks:
   scoped_refptr<IndexedDBDispatcherHost> dispatcher_host_;
   int32 ipc_callbacks_id_;
   int32 ipc_thread_id_;
 
   // IndexedDBCursor callbacks ------------------------
   int32 ipc_cursor_id_;
 
   // IndexedDBDatabase callbacks ------------------------
   int64 host_transaction_id_;
   GURL origin_url_;
   int32 ipc_database_id_;
   int32 ipc_database_callbacks_id_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CALLBACKS_H_