Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4003)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1911643002: Add configurable limit to allocations in heap profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving to use session state Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index 53532b231242ff567e07486f680c1819cf6bb092..1946431d7db44eaa07ba677ee1a49dcc111e98f2 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -654,15 +654,16 @@ void MemoryDumpManager::OnTraceLogEnabled() {
g_periodic_dumps_count = 0;
const TraceConfig trace_config =
TraceLog::GetInstance()->GetCurrentTraceConfig();
- const TraceConfig::MemoryDumpConfig& config_list =
- trace_config.memory_dump_config();
- if (config_list.empty())
+ session_state_->SetMemoryDumpConfig(trace_config.memory_dump_config());
+ std::vector<TraceConfig::MemoryDumpTriggerConfig> triggers_list =
Primiano Tucci (use gerrit) 2016/04/22 14:18:29 can this still be a const& reference instead of co
Maria 2016/04/25 18:37:23 Done.
+ trace_config.memory_dump_config().triggers;
+ if (triggers_list.empty())
return;
uint32_t min_timer_period_ms = std::numeric_limits<uint32_t>::max();
uint32_t heavy_dump_period_ms = 0;
- DCHECK_LE(config_list.size(), 2u);
- for (const TraceConfig::MemoryDumpTriggerConfig& config : config_list) {
+ DCHECK_LE(triggers_list.size(), 2u);
+ for (const TraceConfig::MemoryDumpTriggerConfig& config : triggers_list) {
DCHECK(config.periodic_interval_ms);
if (config.level_of_detail == MemoryDumpLevelOfDetail::DETAILED)
heavy_dump_period_ms = config.periodic_interval_ms;

Powered by Google App Engine
This is Rietveld 408576698