base/trace_event/malloc_dump_provider.cc - Issue 1911643002: Add configurable limit to allocations in heap profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/malloc_dump_provider.cc

Issue 1911643002: Add configurable limit to allocations in heap profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moving to use session state Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/heap_profiler_heap_dump_writer_unittest.cc ('K') | « base/trace_event/heap_profiler_heap_dump_writer_unittest.cc ('k') | base/trace_event/memory_dump_manager.cc » ('j') | base/trace_event/memory_dump_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/malloc_dump_provider.cc

diff --git a/base/trace_event/malloc_dump_provider.cc b/base/trace_event/malloc_dump_provider.cc

index be6efc866a363810bc87057b180624b61c1fabd1..eabe50ee216205740fb5be052be89febecc502fa 100644

--- a/base/trace_event/malloc_dump_provider.cc

+++ b/base/trace_event/malloc_dump_provider.cc

@@ -195,8 +195,7 @@ bool MallocDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,

if (!metrics_by_context.empty()) {

std::unique_ptr<TracedValue> heap_dump = ExportHeapDump(

- metrics_by_context, pmd->session_state()->stack_frame_deduplicator(),

- pmd->session_state()->type_name_deduplicator());

+ metrics_by_context, *pmd->session_state());

Primiano Tucci (use gerrit) 2016/04/22 14:18:29 yes fantastic :)

Maria 2016/04/25 18:37:23 Acknowledged.

pmd->AddHeapDump("malloc", std::move(heap_dump));

}

overhead.DumpInto("tracing/heap_profiler_malloc", pmd);