Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1911603002: LayoutTree machinery (Closed)

Created:
4 years, 8 months ago by benjhayden
Modified:
3 years, 10 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

LayoutTree machinery Currently, LayoutTrees are good for visualizing, but lack a lot of context and structure that are required for metrics to understand what is happening with them. This CL links together subframe LayoutTrees with parent frames' LayoutObjects, and LocalFrames/RenderFrames/FrameTreeNodes. Depends on https://codereview.chromium.org/1864403003 This CL also contains a prototype PUF metric to help the PUF team experiment. That will be removed from this patch before it's mailed out for review.

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : rebase #

Patch Set 10 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -168 lines) Patch
M tracing/trace_viewer.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/extras/chrome/frame_tree_node.html View 1 2 chunks +9 lines, -1 line 0 comments Download
M tracing/tracing/extras/chrome/layout_object.html View 1 2 3 4 5 6 6 chunks +70 lines, -0 lines 0 comments Download
M tracing/tracing/extras/chrome/layout_tree.html View 1 2 3 4 2 chunks +39 lines, -1 line 0 comments Download
M tracing/tracing/extras/chrome/render_frame.html View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M tracing/tracing/metrics/all_metrics.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A tracing/tracing/metrics/puf_metric.html View 1 2 3 4 5 6 7 8 9 1 chunk +98 lines, -0 lines 0 comments Download
M tracing/tracing/ui/analysis/layout_tree_sub_view.html View 1 2 3 4 2 chunks +219 lines, -162 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
benjhayden
Description was changed from ========== ... ========== to ========== LayoutTree machinery Currently, LayoutTrees are good ...
4 years, 8 months ago (2016-04-22 18:11:43 UTC) #1
benjhayden
Description was changed from ========== LayoutTree machinery Currently, LayoutTrees are good for visualizing, but lack ...
4 years, 8 months ago (2016-04-22 18:13:29 UTC) #2
benjhayden
4 years, 8 months ago (2016-04-22 20:28:25 UTC) #3 
Description was changed from

==========
LayoutTree machinery

Currently, LayoutTrees are good for visualizing, but lack a lot of context and
structure that are required for metrics to understand what is happening with
them.

This CL links together subframe LayoutTrees with parent frames' LayoutObjects,
and LocalFrames/RenderFrames/FrameTreeNodes.

This CL also contains a prototype PUF metric to help the PUF team experiment.
That will be removed from this patch before it's mailed out for review.
==========

to

==========
LayoutTree machinery

Currently, LayoutTrees are good for visualizing, but lack a lot of context and
structure that are required for metrics to understand what is happening with
them.

This CL links together subframe LayoutTrees with parent frames' LayoutObjects,
and LocalFrames/RenderFrames/FrameTreeNodes.

Depends on https://codereview.chromium.org/1864403003

This CL also contains a prototype PUF metric to help the PUF team experiment.
That will be removed from this patch before it's mailed out for review.
==========

Powered by Google App Engine
This is Rietveld 408576698