Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1864403003: Trace LayoutObject src attributes and parent frames (Closed)

Created:
4 years, 8 months ago by benjhayden
Modified:
3 years, 10 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trace LayoutObject src attributes and parent frames Put Users First team is working on TBMv2 ads metrics. The first prototype of these metrics will use the layout tree snapshots in traces to find ads' sizes and positions. The positions can be compared with the viewport to find when the ads are on-screen. Currently, the layout tree snapshots indicate every layout object's size, position, and type, so we can find iframes and their sizes, but we can't tell if those iframes are ads. Catapult has a list of a few known ad networks domains, so if TracedLayoutObject traced the 'src' attribute for iframe LayoutObjects, then catapult would be able to tell which iframes are ads. Since snapshotting LayoutTrees is fairly costly, we don't expect to be able to implement UMA using them. We are exploring more efficient methods of computing these metrics while we experiment with computing them in the easy-to-write way using traces. Catapult change: https://codereview.chromium.org/1911603002 BUG=597851 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Patch Set 1 #

Patch Set 2 : puf.top25 benchmark #

Patch Set 3 : 10k #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -9 lines) Patch
M content/renderer/frame_blame_context.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/frame_blame_context.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 4 chunks +8 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp View 1 2 3 4 5 5 chunks +37 lines, -2 lines 1 comment Download
A tools/perf/benchmarks/puf.py View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
benjhayden
4 years, 6 months ago (2016-06-03 18:12:29 UTC) #4
https://codereview.chromium.org/1864403003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1864403003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:1038:
TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(TRACE_DISABLED_BY_DEFAULT("blink.debug.layout"),
"LayoutTree",
comment out for puf

https://codereview.chromium.org/1864403003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp (right):

https://codereview.chromium.org/1864403003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp:39: Element&
element = toElement(*node);
tracedValue->setString("originURL", element.originURL());
if (node->nodeName() == "A") tracedValue->setString("href",
element.getAttribute("href"));

Powered by Google App Engine
This is Rietveld 408576698