Equalizing samples when comparing middle revision against good and bad.

Equalizing samples when comparing middle revision against good and bad.

When examining a revision in the bisect process, we want to decide which
of the halves of the range between 'good' and 'bad' revisions to either
side of the revison being tested is more likely to contain the source of
the regression. By taking into account samples of the same size for
either end of the range, we hope to reduce any bias that the sample size
may impart on the hypothesis test used to perform the comparison.

R=dtu
BUG=597998
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300060

[dtu, 2016-04-20 23:01:17]

lgtm

https://codereview.chromium.org/1911583003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/auto_bisect/revision_state.py (right):

https://codereview.chromium.org/1911583003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/auto_bisect/revision_state.py:548:
self.bisector.fkbr.values))
A little bit weird for taking the min of just two values. Why not just
min(len(lkgr), len(fkbr))?

(In fact, you don't even need to take the min. Your previous strategy of doing
lkgr[:len(fkbr)] and fkbr[:len(lkgr)] works as well.)

(I also notice that this class is reaching into self.bisector a lot, and that's
the code smell "feature envy.")

[RobertoCN, 2016-04-20 23:13:34]

https://codereview.chromium.org/1911583003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/auto_bisect/revision_state.py (right):

https://codereview.chromium.org/1911583003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/auto_bisect/revision_state.py:548:
self.bisector.fkbr.values))
On 2016/04/20 23:01:17, dtu wrote:
> A little bit weird for taking the min of just two values. Why not just
> min(len(lkgr), len(fkbr))?
> 
> (In fact, you don't even need to take the min. Your previous strategy of doing
> lkgr[:len(fkbr)] and fkbr[:len(lkgr)] works as well.)
> 
> (I also notice that this class is reaching into self.bisector a lot, and
that's
> the code smell "feature envy.")

done. 

Agreed. revision_state will be gutted soon.

[RobertoCN, 2016-04-20 23:13:43]

The CQ bit was checked by robertocn@chromium.org

[RobertoCN, 2016-04-20 23:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/1911583003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-04-20 23:13:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911583003/40001

[commit-bot: I haz the power, 2016-04-20 23:17:27]

Description was changed from

==========
Equalizing samples when comparing middle revision against good and bad.

When examining a revision in the bisect process, we want to decide which
of the halves of the range between 'good' and 'bad' revisions to either
side of the revison being tested is more likely to contain the source of
the regression. By taking into account samples of the same size for
either end of the range, we hope to reduce any bias that the sample size
may impart on the hypothesis test used to perform the comparison.

R=dtu
BUG=597998
==========

to

==========
Equalizing samples when comparing middle revision against good and bad.

When examining a revision in the bisect process, we want to decide which
of the halves of the range between 'good' and 'bad' revisions to either
side of the revison being tested is more likely to contain the source of
the regression. By taking into account samples of the same size for
either end of the range, we hope to reduce any bias that the sample size
may impart on the hypothesis test used to perform the comparison.

R=dtu
BUG=597998

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300060
==========

[commit-bot: I haz the power, 2016-04-20 23:17:28]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300060