Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/revision_state.py

Issue 1911583003: Equalizing samples when comparing middle revision against good and bad. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
index 9ba13ff30eb7fd4bb99b3b7ffefb374a6746c946..70b7b90f82686519a221664dd5bc59895555a25d 100644
--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
@@ -539,27 +539,29 @@ class RevisionState(object):
False if they are instead significantly different form those of testing
the latest knwon good revision.
"""
+ lkgr = self.bisector.lkgr
+ fkbr = self.bisector.fkbr
if self.bisector.is_return_code_mode():
- return self.overall_return_code == self.bisector.lkgr.overall_return_code
+ return self.overall_return_code == lkgr.overall_return_code
while True:
diff_from_good = self.bisector.significantly_different(
- self.bisector.lkgr.values, self.values)
+ lkgr.values[:len(fkbr.values)], self.values)
diff_from_bad = self.bisector.significantly_different(
- self.bisector.fkbr.values, self.values)
+ fkbr.values[:len(lkgr.values)], self.values)
if diff_from_good and diff_from_bad:
# Multiple regressions.
# For now, proceed bisecting the biggest difference of the means.
- dist_from_good = abs(self.mean_value - self.bisector.lkgr.mean_value)
- dist_from_bad = abs(self.mean_value - self.bisector.fkbr.mean_value)
+ dist_from_good = abs(self.mean_value - lkgr.mean_value)
+ dist_from_bad = abs(self.mean_value - fkbr.mean_value)
if dist_from_good > dist_from_bad:
# TODO(robertocn): Add way to handle the secondary regression
- #self.bisector.handle_secondary_regression(self, self.bisector.fkbr)
+ #self.bisector.handle_secondary_regression(self, fkbr)
return False
else:
- #self.bisector.handle_secondary_regression(self.bisector.lkgr, self)
+ #self.bisector.handle_secondary_regression(lkgr, self)
return True
if diff_from_good or diff_from_bad: # pragma: no cover
« no previous file with comments | « no previous file | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698