 Chromium Code Reviews
 Chromium Code Reviews Issue 1911573002:
  Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1911573002:
  Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/search/search.cc | 
| diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc | 
| index 645fecb9a52e535b344cc9554331c891695ddc61..0e6a7c608c9936226a9d049c25a684153f10f6a8 100644 | 
| --- a/chrome/browser/search/search.cc | 
| +++ b/chrome/browser/search/search.cc | 
| @@ -493,6 +493,7 @@ GURL GetEffectiveURLForInstant(const GURL& url, Profile* profile) { | 
| // Replace the scheme with "chrome-search:". | 
| 
samarth
2016/04/28 20:25:03
Can you extend this comment to explain why the por
 
ncarter (slow)
2016/04/28 22:21:49
Done.
 | 
| url::Replacements<char> replacements; | 
| std::string search_scheme(chrome::kChromeSearchScheme); | 
| + replacements.ClearPort(); | 
| 
samarth
2016/04/28 20:25:03
nit: this line seems out of order since the search
 
samarth
2016/04/28 20:25:03
Can you add a test for this in search_unittest.cc?
 
ncarter (slow)
2016/04/28 22:21:49
Done.
 
ncarter (slow)
2016/04/28 22:21:49
Done.
 | 
| replacements.SetScheme(search_scheme.data(), | 
| url::Component(0, search_scheme.length())); |