Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/browser/search/search.cc

Issue 1911573002: Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to patch set #4 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/site_instance_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/search.cc
diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc
index 645fecb9a52e535b344cc9554331c891695ddc61..0e6a7c608c9936226a9d049c25a684153f10f6a8 100644
--- a/chrome/browser/search/search.cc
+++ b/chrome/browser/search/search.cc
@@ -493,6 +493,7 @@ GURL GetEffectiveURLForInstant(const GURL& url, Profile* profile) {
// Replace the scheme with "chrome-search:".
samarth 2016/04/28 20:25:03 Can you extend this comment to explain why the por
ncarter (slow) 2016/04/28 22:21:49 Done.
url::Replacements<char> replacements;
std::string search_scheme(chrome::kChromeSearchScheme);
+ replacements.ClearPort();
samarth 2016/04/28 20:25:03 nit: this line seems out of order since the search
samarth 2016/04/28 20:25:03 Can you add a test for this in search_unittest.cc?
ncarter (slow) 2016/04/28 22:21:49 Done.
ncarter (slow) 2016/04/28 22:21:49 Done.
replacements.SetScheme(search_scheme.data(),
url::Component(0, search_scheme.length()));
« no previous file with comments | « no previous file | content/browser/site_instance_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698