Teach SiteInstance::GetSiteForURL() about blob and filesystem URLs.

chrome/browser/search/search.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/search.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
@@ skipping 472 matching lines @@
 
 GURL GetEffectiveURLForInstant(const GURL& url, Profile* profile) {
   CHECK(ShouldAssignURLToInstantRenderer(url, profile))
       << "Error granting Instant access.";
 
   if (url.SchemeIs(chrome::kChromeSearchScheme))
     return url;
 
   GURL effective_url(url);
 
   // Replace the scheme with "chrome-search:".

[samarth, 2016/04/28 20:25:03]

Can you extend this comment to explain why the port is also removed?

[ncarter (slow), 2016/04/28 22:21:49]

Done.

   url::Replacements<char> replacements;
   std::string search_scheme(chrome::kChromeSearchScheme);
+  replacements.ClearPort();

[samarth, 2016/04/28 20:25:03]

nit: this line seems out of order since the search_scheme defined above is used
below this line.  Move it above L495?

[samarth, 2016/04/28 20:25:03]

Can you add a test for this in search_unittest.cc?

[ncarter (slow), 2016/04/28 22:21:49]

Done.

[ncarter (slow), 2016/04/28 22:21:49]

Done.

   replacements.SetScheme(search_scheme.data(),
                          url::Component(0, search_scheme.length()));
 
   // If this is the URL for a server-provided NTP, replace the host with
   // "remote-ntp".
   std::string remote_ntp_host(chrome::kChromeSearchRemoteNtpHost);
   NewTabURLDetails details = NewTabURLDetails::ForProfile(profile);
   if (details.state == NEW_TAB_URL_VALID &&
       MatchesOriginAndPath(url, details.url)) {
     replacements.SetHost(remote_ntp_host.c_str(),
@@ skipping 78 matching lines @@
       kUseAltInstantURL, false, flags);
 }
 
 bool ShouldUseSearchPathForInstant() {
   FieldTrialFlags flags;
   return GetFieldTrialInfo(&flags) && GetBoolValueForFlagWithDefault(
       kUseSearchPathForInstant, false, flags);
 }
 
 }  // namespace search