Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191153004: Provide access to the WindowEventDispatcher as a ui::EventProcessor. (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, ben+aura_chromium.org, ben+corewm_chromium.org, jam, dcheng, joi+watch-content_chromium.org, nona+watch_chromium.org, jochen+watch_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, ben+views_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Provide access to the WindowEventDispatcher as a ui::EventProcessor. This avoids using WED from a number of places and moves us closer to a world where WED is more of an implementation detail of WTH. R=sky@chromium.org TBR=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256053

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -229 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 1 2 3 4 5 chunks +9 lines, -8 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 15 chunks +17 lines, -30 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 11 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 4 46 chunks +56 lines, -55 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/event_generator.h View 5 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/test/event_generator.cc View 11 chunks +13 lines, -14 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 19 chunks +25 lines, -24 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 9 chunks +12 lines, -13 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.h View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/corewm/input_method_event_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/test/views_test_base.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 4 5 chunks +7 lines, -6 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-07 21:07:00 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-07 21:45:51 UTC) #2
Ben Goodger (Google)
6 years, 9 months ago (2014-03-10 22:50:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #5 manually as r256053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698