Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191153002: Fix compiler warning on Win64 (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Fix compiler warning on Win64 BUG=None LOG=N TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19731

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M test/cctest/test-heap-profiler.cc View 2 chunks +7 lines, -7 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
yurys
Committed patchset #1 manually as r19731 (presubmit successful).
6 years, 9 months ago (2014-03-07 17:20:10 UTC) #1
tfarina
https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc#newcode2527 test/cctest/test-heap-profiler.cc:2527: CHECK_EQ(1, static_cast<int>(map.size())); CHECK_EQ(1u, map.size()); ?
6 years, 9 months ago (2014-03-08 02:26:24 UTC) #2
yurys
https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc#newcode2527 test/cctest/test-heap-profiler.cc:2527: CHECK_EQ(1, static_cast<int>(map.size())); On 2014/03/08 02:26:24, tfarina wrote: > CHECK_EQ(1u, ...
6 years, 9 months ago (2014-03-11 07:36:21 UTC) #3
yurys
6 years, 9 months ago (2014-03-11 07:52:34 UTC) #4
Message was sent while issue was closed. 
Hm, there are no overload of CheckEqualsHelper that would accept unsigned type:

../test/cctest/test-heap-profiler.cc:2527:3: error: call of overloaded
'CheckEqualsHelper(const char [37], int, const char [3], unsigned int, const
char [11], size_t)' is ambiguous
../test/cctest/test-heap-profiler.cc:2527:3: note: candidates are:
../src/checks.h:84:13: note: void CheckEqualsHelper(const char*, int, const
char*, int, const char*, int)
../src/checks.h:97:13: note: void CheckEqualsHelper(const char*, int, const
char*, int64_t, const char*, int64_t)
../src/checks.h:196:13: note: void CheckEqualsHelper(const char*, int, const
char*, double, const char*, double)

Powered by Google App Engine
This is Rietveld 408576698