Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 191153002: Fix compiler warning on Win64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index ebd231df33b4149b9c1708d1fb122da2435c29ae..f1ccc571dabcfef9766da81c7f6a367cef469838 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -2524,19 +2524,19 @@ TEST(AddressToTraceMap) {
CHECK_EQ(1, map.GetTraceNodeId(ToAddress(0x100)));
CHECK_EQ(1, map.GetTraceNodeId(ToAddress(0x150)));
CHECK_EQ(0, map.GetTraceNodeId(ToAddress(0x100 + 0x100)));
- CHECK_EQ(1, map.size());
+ CHECK_EQ(1, static_cast<int>(map.size()));
tfarina 2014/03/08 02:26:24 CHECK_EQ(1u, map.size()); ?
yurys 2014/03/11 07:36:21 Good point, thanks, will change it in one of the n
// [0x100, 0x200) -> 1, [0x200, 0x300) -> 2
map.AddRange(ToAddress(0x200), 0x100, 2U);
CHECK_EQ(2, map.GetTraceNodeId(ToAddress(0x2a0)));
- CHECK_EQ(2, map.size());
+ CHECK_EQ(2, static_cast<int>(map.size()));
// [0x100, 0x180) -> 1, [0x180, 0x280) -> 3, [0x280, 0x300) -> 2
map.AddRange(ToAddress(0x180), 0x100, 3U);
CHECK_EQ(1, map.GetTraceNodeId(ToAddress(0x17F)));
CHECK_EQ(2, map.GetTraceNodeId(ToAddress(0x280)));
CHECK_EQ(3, map.GetTraceNodeId(ToAddress(0x180)));
- CHECK_EQ(3, map.size());
+ CHECK_EQ(3, static_cast<int>(map.size()));
// [0x100, 0x180) -> 1, [0x180, 0x280) -> 3, [0x280, 0x300) -> 2,
// [0x400, 0x500) -> 4
@@ -2547,22 +2547,22 @@ TEST(AddressToTraceMap) {
CHECK_EQ(4, map.GetTraceNodeId(ToAddress(0x450)));
CHECK_EQ(0, map.GetTraceNodeId(ToAddress(0x500)));
CHECK_EQ(0, map.GetTraceNodeId(ToAddress(0x350)));
- CHECK_EQ(4, map.size());
+ CHECK_EQ(4, static_cast<int>(map.size()));
// [0x100, 0x180) -> 1, [0x180, 0x200) -> 3, [0x200, 0x600) -> 5
map.AddRange(ToAddress(0x200), 0x400, 5U);
CHECK_EQ(5, map.GetTraceNodeId(ToAddress(0x200)));
CHECK_EQ(5, map.GetTraceNodeId(ToAddress(0x400)));
- CHECK_EQ(3, map.size());
+ CHECK_EQ(3, static_cast<int>(map.size()));
// [0x100, 0x180) -> 1, [0x180, 0x200) -> 7, [0x200, 0x600) ->5
map.AddRange(ToAddress(0x180), 0x80, 6U);
map.AddRange(ToAddress(0x180), 0x80, 7U);
CHECK_EQ(7, map.GetTraceNodeId(ToAddress(0x180)));
CHECK_EQ(5, map.GetTraceNodeId(ToAddress(0x200)));
- CHECK_EQ(3, map.size());
+ CHECK_EQ(3, static_cast<int>(map.size()));
map.Clear();
- CHECK_EQ(0, map.size());
+ CHECK_EQ(0, static_cast<int>(map.size()));
CHECK_EQ(0, map.GetTraceNodeId(ToAddress(0x400)));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698