Make the maximize button more easily hittable when there is a huge amount of tabs present

chrome/browser/ui/views/frame/browser_view_layout.cc

Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index a015739735db702a0e7db047c136ab4075dffc7f..04d1028c25aec967579e86e5cf1c3ec7834ffb3f 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -249,13 +249,25 @@ gfx::Rect BrowserViewLayout::GetFindBarBoundingBox() const {
 
 bool BrowserViewLayout::IsPositionInWindowCaption(
     const gfx::Point& point) {
-  // Tab strip may transiently have no parent between the RemoveChildView() and
-  // AddChildView() caused by reparenting during an immersive mode reveal.
-  // During this window report that the point didn't hit a tab.
-  if (!tab_strip_->parent())
-    return true;
+  views::View* window_switcher_button = delegate_->GetWindowSwitcherButton();
+  if (window_switcher_button) {
+    gfx::Point window_switcher_point(point);
+    views::View::ConvertPointToTarget(browser_view_, window_switcher_button,
+                                      &window_switcher_point);
+    if (window_switcher_button->HitTestPoint(window_switcher_point))
+      return false;
+  }
+
   gfx::Point tabstrip_point(point);
   views::View::ConvertPointToTarget(browser_view_, tab_strip_, &tabstrip_point);
+
+  // NonClientFrameView::HitTestRect() should have filtered out any points
+  // below |tab_strip_|.
+  DCHECK_LE(point.y(), tab_strip_->bounds().bottom());
+
+  // The window controls are in the non client view.
+  if (!tab_strip_->HitTestPoint(tabstrip_point))

[James Cook, 2013/07/12 23:12:12]

Is there some other way to do this?  In particular, you're changing the
semantics of this function to mean something like "Is this position, which I
know is above the bottom of the tab strip, really overlapping the tab strip or
is it in the window caption?"  While the only *current* caller of the function
filters out points beneath the tab strip, I think it's very easy for someone to
assume they'll get a correct answer calling this function for any arbitrary
point.

Could the checking be pushed up into BrowserNonClientFrameViewAsh?  Or explicit
checks added somewhere for the size/close buttons?

(Also, what about tab strip visibility?)

+    return true;
   return tab_strip_->IsPositionInWindowCaption(tabstrip_point);
 }