Make the maximize button more easily hittable when there is a huge amount of tabs present

chrome/browser/ui/views/frame/browser_view_layout.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
 
 #include "base/observer_list.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 231 matching lines @@
   int scrollbar_width = gfx::scrollbar_size();
   bounding_box.set_width(std::max(0, bounding_box.width() - scrollbar_width));
   if (base::i18n::IsRTL())
     bounding_box.set_x(bounding_box.x() + scrollbar_width);
 
   return bounding_box;
 }
 
 bool BrowserViewLayout::IsPositionInWindowCaption(
     const gfx::Point& point) {
-  // Tab strip may transiently have no parent between the RemoveChildView() and
-  // AddChildView() caused by reparenting during an immersive mode reveal.
-  // During this window report that the point didn't hit a tab.
-  if (!tab_strip_->parent())
-    return true;
+  views::View* window_switcher_button = delegate_->GetWindowSwitcherButton();
+  if (window_switcher_button) {
+    gfx::Point window_switcher_point(point);
+    views::View::ConvertPointToTarget(browser_view_, window_switcher_button,
+                                      &window_switcher_point);
+    if (window_switcher_button->HitTestPoint(window_switcher_point))
+      return false;
+  }
+
   gfx::Point tabstrip_point(point);
   views::View::ConvertPointToTarget(browser_view_, tab_strip_, &tabstrip_point);
+
+  // NonClientFrameView::HitTestRect() should have filtered out any points
+  // below |tab_strip_|.
+  DCHECK_LE(point.y(), tab_strip_->bounds().bottom());
+
+  // The window controls are in the non client view.
+  if (!tab_strip_->HitTestPoint(tabstrip_point))

[James Cook, 2013/07/12 23:12:12]

Is there some other way to do this?  In particular, you're changing the
semantics of this function to mean something like "Is this position, which I
know is above the bottom of the tab strip, really overlapping the tab strip or
is it in the window caption?"  While the only *current* caller of the function
filters out points beneath the tab strip, I think it's very easy for someone to
assume they'll get a correct answer calling this function for any arbitrary
point.

Could the checking be pushed up into BrowserNonClientFrameViewAsh?  Or explicit
checks added somewhere for the size/close buttons?

(Also, what about tab strip visibility?)

+    return true;
   return tab_strip_->IsPositionInWindowCaption(tabstrip_point);
 }
 
 int BrowserViewLayout::NonClientHitTest(
     const gfx::Point& point) {
   // Since the TabStrip only renders in some parts of the top of the window,
   // the un-obscured area is considered to be part of the non-client caption
   // area of the window. So we need to treat hit-tests in these regions as
   // hit-tests of the titlebar.
 
@@ skipping 372 matching lines @@
   return bottom;
 }
 
 bool BrowserViewLayout::InfobarVisible() const {
   // Cast to a views::View to access GetPreferredSize().
   views::View* infobar_container = infobar_container_;
   // NOTE: Can't check if the size IsEmpty() since it's always 0-width.
   return browser_->SupportsWindowFeature(Browser::FEATURE_INFOBAR) &&
       (infobar_container->GetPreferredSize().height() != 0);
 }