Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1911473002: Rename transformToRoot:ish names to screenScaleFactorChanged:ish ones (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-hiddencontainer-layout-no-xfrmchg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename transformToRoot:ish names to screenScaleFactorChanged:ish ones This better reflects the function of this machinery, since it's used to update the scale of fonts based on the computed "screen scale factor". BUG=603956 Committed: https://crrev.com/fd51da99e43dcce990befd948740515e7a4a2900 Cr-Commit-Position: refs/heads/master@{#388749}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment in LayoutSVGText. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
fs
This is bikeshed-fodder: I've picked 'screen' to be included in the name because that's (one ...
4 years, 8 months ago (2016-04-20 17:42:04 UTC) #2
Stephen Chennney
On 2016/04/20 17:42:04, fs wrote: > This is bikeshed-fodder: I've picked 'screen' to be included ...
4 years, 8 months ago (2016-04-20 19:36:31 UTC) #3
f(malita)
https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp#newcode59 third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:59: m_didScreenScaleFactorChange = updatedTransform || SVGLayoutSupport::screenScaleFactorChanged(parent()); If we only care ...
4 years, 8 months ago (2016-04-20 20:00:32 UTC) #4
fs
https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp#newcode59 third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:59: m_didScreenScaleFactorChange = updatedTransform || SVGLayoutSupport::screenScaleFactorChanged(parent()); On 2016/04/20 at 20:00:32, ...
4 years, 8 months ago (2016-04-20 20:18:20 UTC) #5
f(malita)
On 2016/04/20 20:18:20, fs wrote: > https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp > File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): > > https://codereview.chromium.org/1911473002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp#newcode59 > ...
4 years, 8 months ago (2016-04-20 20:20:30 UTC) #6
pdr.
LGTM3 with a meta-question (LGTM regardless of the answer): is updating the font after scaling ...
4 years, 8 months ago (2016-04-20 22:48:32 UTC) #7
fs
On 2016/04/20 at 22:48:32, pdr wrote: > LGTM3 with a meta-question (LGTM regardless of the ...
4 years, 8 months ago (2016-04-21 10:43:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911473002/20001
4 years, 8 months ago (2016-04-21 11:58:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 12:17:28 UTC) #12
pdr.
On 2016/04/21 at 10:43:39, fs wrote: > On 2016/04/20 at 22:48:32, pdr wrote: > > ...
4 years, 8 months ago (2016-04-21 19:00:00 UTC) #13
fs
On 2016/04/21 at 19:00:00, pdr wrote: > On 2016/04/21 at 10:43:39, fs wrote: > > ...
4 years, 8 months ago (2016-04-21 19:20:54 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:33:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd51da99e43dcce990befd948740515e7a4a2900
Cr-Commit-Position: refs/heads/master@{#388749}

Powered by Google App Engine
This is Rietveld 408576698