Rename transformToRoot:ish names to screenScaleFactorChanged:ish ones

third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.  All rights reserved.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 18 matching lines @@
 #include "core/layout/svg/SVGResources.h"
 #include "core/layout/svg/SVGResourcesCache.h"
 #include "core/paint/SVGContainerPainter.h"
 
 namespace blink {
 
 LayoutSVGContainer::LayoutSVGContainer(SVGElement* node)
     : LayoutSVGModelObject(node)
     , m_objectBoundingBoxValid(false)
     , m_needsBoundariesUpdate(true)
-    , m_didTransformToRootUpdate(false)
+    , m_didScreenScaleFactorChange(false)
     , m_hasNonIsolatedBlendingDescendants(false)
     , m_hasNonIsolatedBlendingDescendantsDirty(false)
 {
 }
 
 LayoutSVGContainer::~LayoutSVGContainer()
 {
 }
 
 void LayoutSVGContainer::layout()
 {
     ASSERT(needsLayout());
     LayoutAnalyzer::Scope analyzer(*this);
 
     // Allow LayoutSVGViewportContainer to update its viewport.
     calcViewport();
 
     // Allow LayoutSVGTransformableContainer to update its transform.
     bool updatedTransform = calculateLocalTransform();
-    m_didTransformToRootUpdate = updatedTransform || SVGLayoutSupport::transformToRootChanged(parent());
+    m_didScreenScaleFactorChange = updatedTransform || SVGLayoutSupport::screenScaleFactorChanged(parent());

[f(malita), 2016/04/20 20:00:32]

If we only care about scale factor changes, then this looks too conservative.  I
presume we could do something smart about it (only track actual scale changes),
or tweak the name to reflect the current reality:
s/screenScaleChanged/screenTransformChanged/

I'm fine with landing as-is too, if the plan is to fix reality later :)

[fs, 2016/04/20 20:18:20]

Right, it was "undisclosed" that I intend to make this less conservative by
replacing the "updatedTransform" bit with something tighter in a follow-up CL.

 
     // LayoutSVGViewportContainer needs to set the 'layout size changed' flag.
     determineIfLayoutSizeChanged();
 
     // When hasRelativeLengths() is false, no descendants have relative lengths
     // (hence no one is interested in viewport size changes).
     bool layoutSizeChanged = element()->hasRelativeLengths()
         && SVGLayoutSupport::layoutSizeOfNearestViewportChanged(this);
 
     // If any of this container's children need to be laid out, and a filter is
     // applied to the container, we need to issue paint invalidations for all
     // the descendants.
     bool forceLayoutOfChildren = selfNeedsLayout()
         || (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*this));
-    SVGLayoutSupport::layoutChildren(firstChild(), forceLayoutOfChildren, m_didTransformToRootUpdate, layoutSizeChanged);
+    SVGLayoutSupport::layoutChildren(firstChild(), forceLayoutOfChildren, m_didScreenScaleFactorChange, layoutSizeChanged);
 
     // Invalidate all resources of this client if our layout changed.
     if (everHadLayout() && needsLayout())
         SVGResourcesCache::clientLayoutChanged(this);
 
     if (m_needsBoundariesUpdate || updatedTransform) {
         updateCachedBoundaries();
         m_needsBoundariesUpdate = false;
 
         // If our bounds changed, notify the parents.
@@ skipping 113 matching lines @@
             updateHitTestResult(result, localLayoutPoint);
             if (result.addNodeToListBasedTestResult(element(), localLayoutPoint) == StopHitTesting)
                 return true;
         }
     }
     // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispatched."
     return false;
 }
 
 } // namespace blink