Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/compiler.cc

Issue 1911313002: Pass debug name as Vector instead of const char* (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-1
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 298955f1e0f4edd2cfa389ae9e7d70f05032790a..ca9cccd32b2a7ce9f62d8255513e90f17e35eff2 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -121,8 +121,8 @@ bool CompilationInfo::has_shared_info() const {
CompilationInfo::CompilationInfo(ParseInfo* parse_info,
Handle<JSFunction> closure)
- : CompilationInfo(parse_info, nullptr, Code::ComputeFlags(Code::FUNCTION),
- BASE, parse_info->isolate(), parse_info->zone()) {
+ : CompilationInfo(parse_info, {}, Code::ComputeFlags(Code::FUNCTION), BASE,
+ parse_info->isolate(), parse_info->zone()) {
closure_ = closure;
// Compiling for the snapshot typically results in different code than
@@ -139,12 +139,13 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info,
if (FLAG_turbo_splitting) MarkAsSplittingEnabled();
}
-
-CompilationInfo::CompilationInfo(const char* debug_name, Isolate* isolate,
- Zone* zone, Code::Flags code_flags)
+CompilationInfo::CompilationInfo(Vector<const char> debug_name,
+ Isolate* isolate, Zone* zone,
+ Code::Flags code_flags)
: CompilationInfo(nullptr, debug_name, code_flags, STUB, isolate, zone) {}
-CompilationInfo::CompilationInfo(ParseInfo* parse_info, const char* debug_name,
+CompilationInfo::CompilationInfo(ParseInfo* parse_info,
+ Vector<const char> debug_name,
Code::Flags code_flags, Mode mode,
Isolate* isolate, Zone* zone)
: parse_info_(parse_info),
@@ -165,7 +166,6 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info, const char* debug_name,
osr_expr_stack_height_(0),
debug_name_(debug_name) {}
-
CompilationInfo::~CompilationInfo() {
DisableFutureOptimization();
delete deferred_handles_;
@@ -268,10 +268,11 @@ base::SmartArrayPointer<char> CompilationInfo::GetDebugName() const {
if (parse_info() && !parse_info()->shared_info().is_null()) {
return parse_info()->shared_info()->DebugName()->ToCString();
}
- const char* str = debug_name_ ? debug_name_ : "unknown";
- size_t len = strlen(str) + 1;
- base::SmartArrayPointer<char> name(new char[len]);
- memcpy(name.get(), str, len);
+ Vector<const char> name_vec = debug_name_;
+ if (name_vec.is_empty()) name_vec = ArrayVector("unknown");
+ base::SmartArrayPointer<char> name(new char[name_vec.length() + 1]);
+ memcpy(name.get(), name_vec.start(), name_vec.length());
+ name[name_vec.length()] = '\0';
return name;
}
« no previous file with comments | « src/compiler.h ('k') | src/compiler/pipeline.cc » ('j') | src/wasm/wasm-opcodes.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698