src/wasm/wasm-opcodes.h - Issue 1911313002: Pass debug name as Vector instead of const char*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-opcodes.h

Issue 1911313002: Pass debug name as Vector instead of const char* (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-1

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/wasm-opcodes.h

diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h

index 1a3aa9cf2a3610b69ed358c957e14a2dabece652..7b5ed9cbf4d460a2ef70f9be4cfdd3665db32c22 100644

--- a/src/wasm/wasm-opcodes.h

+++ b/src/wasm/wasm-opcodes.h

@@ -52,6 +52,10 @@ std::ostream& operator<<(std::ostream& os, const FunctionSig& function);

struct WasmName {

const char* name;

uint32_t length;

+ // TODO(clemensh): Remove whole WasmName, replace by Vector<const char>

+ inline Vector<const char> toVec() const {

titzer 2016/04/26 12:45:57 We don't need this little helper function. Either

Clemens Hammacher 2016/04/26 12:58:52 Sorry, forgot to mention that. The TODO will be ha

+ return Vector<const char>(name, length);

+ }

};

// TODO(titzer): Renumber all the opcodes to fill in holes.

« no previous file with comments | « src/vector.h ('k') | test/cctest/compiler/codegen-tester.h » ('j') | no next file with comments »