Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/compiler.h

Issue 1911313002: Pass debug name as Vector instead of const char* (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-1
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index 109940056376f97559dc2e9ec4e6932633b0efce..9a87bf4f81caf0c77e913694ff47107fdd20937d 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -165,7 +165,8 @@ class CompilationInfo {
};
CompilationInfo(ParseInfo* parse_info, Handle<JSFunction> closure);
- CompilationInfo(const char* debug_name, Isolate* isolate, Zone* zone,
+ CompilationInfo(Vector<const char> function_name, Isolate* isolate,
+ Zone* zone,
Code::Flags code_flags = Code::ComputeFlags(Code::STUB));
virtual ~CompilationInfo();
@@ -461,6 +462,8 @@ class CompilationInfo {
base::SmartArrayPointer<char> GetDebugName() const;
+ Vector<const char> GetFunctionName() const { return function_name_; }
titzer 2016/04/22 11:46:30 If this is only called internally, I would recomme
Clemens Hammacher 2016/04/22 13:47:54 OK, dropped it.
+
Code::Kind output_code_kind() const {
return Code::ExtractKindFromFlags(code_flags_);
}
@@ -498,7 +501,7 @@ class CompilationInfo {
STUB
};
- CompilationInfo(ParseInfo* parse_info, const char* debug_name,
+ CompilationInfo(ParseInfo* parse_info, Vector<const char> function_name,
Code::Flags code_flags, Mode mode, Isolate* isolate,
Zone* zone);
@@ -562,7 +565,7 @@ class CompilationInfo {
// The current OSR frame for specialization or {nullptr}.
JavaScriptFrame* osr_frame_ = nullptr;
- const char* debug_name_;
+ Vector<const char> function_name_;
DISALLOW_COPY_AND_ASSIGN(CompilationInfo);
};
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/compiler.cc » ('j') | src/compiler/wasm-compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698