Pass debug name as Vector instead of const char*

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include "src/allocation.h"
 #include "src/ast/ast.h"
 #include "src/bailout-reason.h"
@@ skipping 147 matching lines @@
     kDisableFutureOptimization = 1 << 12,
     kSplittingEnabled = 1 << 13,
     kDeoptimizationEnabled = 1 << 14,
     kSourcePositionsEnabled = 1 << 15,
     kEffectSchedulingEnabled = 1 << 16,
     kBailoutOnUninitialized = 1 << 17,
     kOptimizeFromBytecode = 1 << 18,
   };
 
   CompilationInfo(ParseInfo* parse_info, Handle<JSFunction> closure);
-  CompilationInfo(const char* debug_name, Isolate* isolate, Zone* zone,
+  CompilationInfo(Vector<const char> function_name, Isolate* isolate,
+                  Zone* zone,
                   Code::Flags code_flags = Code::ComputeFlags(Code::STUB));
   virtual ~CompilationInfo();
 
   ParseInfo* parse_info() const { return parse_info_; }
 
   // -----------------------------------------------------------
   // TODO(titzer): inline and delete accessors of ParseInfo
   // -----------------------------------------------------------
   Handle<Script> script() const;
   bool is_eval() const;
@@ skipping 275 matching lines @@
   InlinedFunctionList const& inlined_functions() const {
     return inlined_functions_;
   }
 
   void AddInlinedFunction(Handle<SharedFunctionInfo> inlined_function) {
     inlined_functions_.push_back(InlinedFunctionHolder(inlined_function));
   }
 
   base::SmartArrayPointer<char> GetDebugName() const;
 
+  Vector<const char> GetFunctionName() const { return function_name_; }

[titzer, 2016/04/22 11:46:30]

If this is only called internally, I would recommend dropping it.

[Clemens Hammacher, 2016/04/22 13:47:54]

OK, dropped it.

+
   Code::Kind output_code_kind() const {
     return Code::ExtractKindFromFlags(code_flags_);
   }
 
   StackFrame::Type GetOutputStackFrameType() const;
 
  protected:
   ParseInfo* parse_info_;
 
   void DisableFutureOptimization() {
@@ skipping 17 matching lines @@
  private:
   // Compilation mode.
   // BASE is generated by the full codegen, optionally prepared for bailouts.
   // OPTIMIZE is optimized code generated by the Hydrogen-based backend.
   enum Mode {
     BASE,
     OPTIMIZE,
     STUB
   };
 
-  CompilationInfo(ParseInfo* parse_info, const char* debug_name,
+  CompilationInfo(ParseInfo* parse_info, Vector<const char> function_name,
                   Code::Flags code_flags, Mode mode, Isolate* isolate,
                   Zone* zone);
 
   Isolate* isolate_;
 
   void SetMode(Mode mode) {
     mode_ = mode;
   }
 
   void SetFlag(Flag flag) { flags_ |= flag; }
@@ skipping 43 matching lines @@
   // Number of parameters used for compilation of stubs that require arguments.
   int parameter_count_;
 
   int optimization_id_;
 
   int osr_expr_stack_height_;
 
   // The current OSR frame for specialization or {nullptr}.
   JavaScriptFrame* osr_frame_ = nullptr;
 
-  const char* debug_name_;
+  Vector<const char> function_name_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilationInfo);
 };
 
 // A base class for compilation jobs intended to run concurrent to the main
 // thread. The job is split into three phases which are called in sequence on
 // different threads and with different limitations:
 //  1) CreateGraph:   Runs on main thread. No major limitations.
 //  2) OptimizeGraph: Runs concurrently. No heap allocation or handle derefs.
 //  3) GenerateCode:  Runs on main thread. No dependency changes.
@@ skipping 50 matching lines @@
   MUST_USE_RESULT Status SetLastStatus(Status status) {
     last_status_ = status;
     return last_status_;
   }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_H_