Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/rebaseline_imagefiles.py

Issue 19112002: svndiff.py: add ability to compare before-and-after JSON files, not just raw images (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: incorporate_feedback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gm/gm_json.py ('K') | « tools/rebaseline.py ('k') | tools/svndiff.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/rebaseline_imagefiles.py
===================================================================
--- tools/rebaseline_imagefiles.py (revision 10016)
+++ tools/rebaseline_imagefiles.py (working copy)
@@ -77,7 +77,7 @@
self._missing_json_is_fatal = missing_json_is_fatal
self._googlestorage_gm_actuals_root = (
'http://chromium-skia-gm.commondatastorage.googleapis.com/gm')
- self._testname_pattern = re.compile('(\S+)_(\S+).png')
+ self._testname_pattern = re.compile(gm_json.IMAGE_FILENAME_PATTERN)
self._is_svn_checkout = (
os.path.exists(os.path.join(expectations_root, '.svn')) or
os.path.exists(os.path.join(expectations_root, os.pardir, '.svn')))
« gm/gm_json.py ('K') | « tools/rebaseline.py ('k') | tools/svndiff.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698