tools/rebaseline.py - Issue 19112002: svndiff.py: add ability to compare before-and-after JSON files, not just raw images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/rebaseline.py

Issue 19112002: svndiff.py: add ability to compare before-and-after JSON files, not just raw images (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: incorporate_feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/rebaseline.py

===================================================================

--- tools/rebaseline.py (revision 10022)

+++ tools/rebaseline.py (working copy)

@@ -101,7 +101,7 @@

self._actuals_base_url = actuals_base_url

self._actuals_filename = actuals_filename

self._add_new = add_new

- self._testname_pattern = re.compile('(\S+)_(\S+).png')

+ self._testname_pattern = re.compile(gm_json.IMAGE_FILENAME_PATTERN)

# Returns the full contents of filepath, as a single string.

# If filepath looks like a URL, try to read it that way instead of as

« gm/gm_json.py ('K') | « tools/jsondiff.py ('k') | tools/rebaseline_imagefiles.py » ('j') | no next file with comments »