Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 19112002: svndiff.py: add ability to compare before-and-after JSON files, not just raw images (Closed)

Created:
7 years, 5 months ago by epoger
Modified:
7 years, 5 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

svndiff.py: add ability to compare before-and-after JSON files, not just raw images This should complete step 3 of https://goto.google.com/ChecksumTransitionDetail ! R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=10113

Patch Set 1 #

Total comments: 11

Patch Set 2 : incorporate_feedback #

Total comments: 2

Patch Set 3 : sync_to_r10108 #

Patch Set 4 : add_CreateGmActualURL #

Total comments: 7

Patch Set 5 : add_todos_for_indent #

Patch Set 6 : linewraps #

Patch Set 7 : sync_to_r10112 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -48 lines) Patch
M gm/gm_json.py View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
M tools/jsondiff.py View 1 2 3 4 5 6 2 chunks +23 lines, -15 lines 0 comments Download
M tools/rebaseline.py View 1 2 3 4 5 6 4 chunks +10 lines, -6 lines 0 comments Download
M tools/rebaseline_imagefiles.py View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M tools/svndiff.py View 1 2 3 4 5 6 6 chunks +123 lines, -20 lines 0 comments Download
M tools/verify_images_for_gm_results.py View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
epoger
Ready for review at patchset 1! https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py#newcode1 tools/svndiff.py:1: #!/usr/bin/python Tested as ...
7 years, 5 months ago (2013-07-12 18:55:00 UTC) #1
epoger
P.S. I guess we'll need a git equivalent of this, too. It should be able ...
7 years, 5 months ago (2013-07-12 18:59:06 UTC) #2
borenet
https://codereview.chromium.org/19112002/diff/1/tools/jsondiff.py File tools/jsondiff.py (right): https://codereview.chromium.org/19112002/diff/1/tools/jsondiff.py#newcode162 tools/jsondiff.py:162: if __name__ == '__main__': I'd prefer having most of ...
7 years, 5 months ago (2013-07-12 19:48:04 UTC) #3
epoger
Thanks, Eric, definitely a couple of good catches in there! Please see patchset 2 (patchset ...
7 years, 5 months ago (2013-07-16 17:29:55 UTC) #4
borenet
https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py#newcode111 tools/svndiff.py:111: """ On 2013/07/16 17:29:55, epoger wrote: > On 2013/07/12 ...
7 years, 5 months ago (2013-07-16 17:42:13 UTC) #5
epoger
PTAL at patchset 4 https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.chromium.org/19112002/diff/1/tools/svndiff.py#newcode111 tools/svndiff.py:111: """ On 2013/07/16 17:42:13, borenet ...
7 years, 5 months ago (2013-07-16 18:22:48 UTC) #6
borenet
LGTM with a few nits https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py File tools/rebaseline.py (right): https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py#newcode188 tools/rebaseline.py:188: (test, config) = self._image_filename_re.match(image_name).groups() ...
7 years, 5 months ago (2013-07-16 18:31:03 UTC) #7
epoger
https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py File tools/rebaseline.py (right): https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py#newcode188 tools/rebaseline.py:188: (test, config) = self._image_filename_re.match(image_name).groups() On 2013/07/16 18:31:03, borenet wrote: ...
7 years, 5 months ago (2013-07-16 18:42:32 UTC) #8
borenet
https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py File tools/rebaseline.py (right): https://codereview.chromium.org/19112002/diff/12002/tools/rebaseline.py#newcode188 tools/rebaseline.py:188: (test, config) = self._image_filename_re.match(image_name).groups() On 2013/07/16 18:42:32, epoger wrote: ...
7 years, 5 months ago (2013-07-16 18:48:37 UTC) #9
epoger
On 2013/07/16 18:48:37, borenet wrote: > It's ugly, but what about: > (test, config) = ...
7 years, 5 months ago (2013-07-16 18:54:52 UTC) #10
epoger
7 years, 5 months ago (2013-07-16 18:56:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 manually as r10113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698