svndiff.py: add ability to compare before-and-after JSON files, not just raw images

gm/gm_json.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Schema of the JSON summary file written out by the GM tool.
 
 This must be kept in sync with the kJsonKey_ constants in gm_expectations.cpp !
 """
 
@@ skipping 31 matching lines @@
 # expectations, and the test will pass if any one of them is matched.
 JSONKEY_EXPECTEDRESULTS_ALLOWEDDIGESTS = 'allowed-digests'
 # If IGNOREFAILURE is set to True, a failure of this test will be reported
 # within the FAILUREIGNORED section (thus NOT causing the buildbots to go red)
 # rather than the FAILED section (which WOULD cause the buildbots to go red).
 JSONKEY_EXPECTEDRESULTS_IGNOREFAILURE = 'ignore-failure'
 
 # Allowed hash types for test expectations.
 JSONKEY_HASHTYPE_BITMAP_64BITMD5 = 'bitmap-64bitMD5'
 
+# Pattern used to assemble each image's filename
+IMAGE_FILENAME_PATTERN = '(\S+)_(\S+).png'  # matches (testname, config)

[borenet, 2013/07/16 17:42:13]

Any reason we can't just make this:
IMAGE_FILENAME_RE = re.compile('(\S+)_(\S+).png')
?

[epoger, 2013/07/16 18:22:48]

I think it's better to keep it as a pattern string for the canonical definition,
so that the string can be modified (e.g. assembled into a longer regular
expression) if desired.  Can't go back the other way, from regexp to string...

+
+
 def LoadFromString(file_contents):
   """Loads the JSON summary written out by the GM tool.
      Returns a dictionary keyed by the values listed as JSONKEY_ constants
      above."""
   # TODO(epoger): we should add a version number to the JSON file to ensure
   # that the writer and reader agree on the schema (raising an exception
   # otherwise).
   json_dict = json.loads(file_contents)
   return json_dict
 
 def LoadFromFile(file_path):
   """Loads the JSON summary written out by the GM tool.
      Returns a dictionary keyed by the values listed as JSONKEY_ constants
      above."""
   file_contents = open(file_path, 'r').read()
   return LoadFromString(file_contents)
 
 def WriteToFile(json_dict, file_path):
   """Writes the JSON summary in json_dict out to file_path."""
   with open(file_path, 'w') as outfile:
     json.dump(json_dict, outfile, sort_keys=True, indent=2)