third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html - Issue 1910933002: bluetooth: Separate requestDevice tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html

Issue 1910933002: bluetooth: Separate requestDevice tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-gatt-connect

Patch Set: Merge Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-lenght-name-namePrefix.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-fails-to-start.html ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/filter-does-not-match.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/processing-user-gesture.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 let devices = [];

	9 let push = device => devices.push(device);

	10 return setBluetoothFakeAdapter('HeartRateAdapter')

	11 .then(() => requestDeviceWithKeyDown({
	Jeffrey Yasskin 2016/05/09 22:09:58 Comment why you can't do this in parallel. (Becaus Comment why you can't do this in parallel. (Because Chrome would always close one in the process of handling the user gesture for the next one, right?) ortuno 2016/05/11 19:29:39 Yup. Done. Show quoted text On 2016/05/09 at 22:09:58, Jeffrey Yasskin wrote: > Comment why you can't do this in parallel. (Because Chrome would always close one in the process of handling the user gesture for the next one, right?) Yup. Done.
	12 filters: [{services: [heart_rate.alias]}]}))

	13 .then(push)

	14 .then(() => requestDeviceWithKeyDown({

	15 filters: [{services: [heart_rate.name]}]}))

	16 .then(push)

	17 .then(() => requestDeviceWithKeyDown({

	18 filters: [{services: [heart_rate.uuid]}]}))

	19 .then(push)

	20 .then(() => {

	21 devices.forEach(device => {

	22 assert_equals(device.constructor.name, 'BluetoothDevice');

	23 });

	24 });

	25 }, 'Mock will resolve.');

	26 </script>

OLD	NEW