Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1910853002:
Keep prefixed project names in the bug list using roll_angle.py. (Closed)
|
Created:
4 years, 8 months ago by Geoff Lang Modified:
4 years, 8 months ago Reviewers:
Jamie Madill CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionKeep prefixed project names in the bug list using roll_angle.py.
BUG IDs such as 'BUG=chromium:X' were being ignored because the script
only searched for integer bug IDs. Updated to allow any bug ID except
ones prefixed with 'angleproject'.
BUG=605115
Committed: https://crrev.com/11c1f24c26068ecbcbb2ab56c8d7ce1b8aa69ad7
Cr-Commit-Position: refs/heads/master@{#389551}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. Updated the 'git cl upload' to use the --bypass-hooks flag. Uploading without this flag can sometimes cause issues on Windows when presubmit scripts check for incorrect line endings. BUG=605115 ========== to ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. Updated the 'git cl upload' to use the --bypass-hooks flag. Uploading without this flag can sometimes cause issues on Windows when presubmit scripts check for incorrect line endings. BUG=605115 ==========
geofflang@chromium.org changed reviewers: + jmadill@chromium.org
PTAL Doesn't have a ton of testing yet but it continues to ignore 'angleproject:X' CLs.
rest seems good, but I don't know if I am comfortable with the bypass hooks, that seems dangerous. I think we should probably just file a bug for the windows presubmit problem and fix that than create this kind of debt.
Presubmit script seems to have fixed itself finally.
Description was changed from ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. Updated the 'git cl upload' to use the --bypass-hooks flag. Uploading without this flag can sometimes cause issues on Windows when presubmit scripts check for incorrect line endings. BUG=605115 ========== to ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. Updated the 'git cl upload' to use the --bypass-hooks flag. Uploading without this flag can sometimes cause issues on Windows when presubmit scripts check for incorrect line endings. BUG=605115 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. Updated the 'git cl upload' to use the --bypass-hooks flag. Uploading without this flag can sometimes cause issues on Windows when presubmit scripts check for incorrect line endings. BUG=605115 ========== to ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. BUG=605115 ==========
Removed the --bypass-hooks flag.
LGTM!
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910853002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910853002/60001
Message was sent while issue was closed.
Description was changed from ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. BUG=605115 ========== to ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. BUG=605115 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. BUG=605115 ========== to ========== Keep prefixed project names in the bug list using roll_angle.py. BUG IDs such as 'BUG=chromium:X' were being ignored because the script only searched for integer bug IDs. Updated to allow any bug ID except ones prefixed with 'angleproject'. BUG=605115 Committed: https://crrev.com/11c1f24c26068ecbcbb2ab56c8d7ce1b8aa69ad7 Cr-Commit-Position: refs/heads/master@{#389551} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/11c1f24c26068ecbcbb2ab56c8d7ce1b8aa69ad7 Cr-Commit-Position: refs/heads/master@{#389551} |
