Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/roll_angle.py

Issue 1910853002: Keep prefixed project names in the bug list using roll_angle.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/roll_angle.py
diff --git a/tools/roll_angle.py b/tools/roll_angle.py
index 6432cc4a093760086393a1049c335444478d6119..2b253ee56ee7c36cf206d1b874d1e7a1d3725bc9 100755
--- a/tools/roll_angle.py
+++ b/tools/roll_angle.py
@@ -102,7 +102,7 @@ def _GenerateCLDescriptionCommand(angle_current, angle_new, bugs, tbr):
def GetBugString(bugs):
bug_str = 'BUG='
for bug in bugs:
- bug_str += str(bug) + ','
+ bug_str += bug + ','
return bug_str.rstrip(',')
if angle_current.git_commit != angle_new.git_commit:
@@ -219,6 +219,7 @@ class AutoRoller(object):
['git','log',
'%s..%s' % (angle_current.git_commit, angle_new.git_commit)],
working_dir=working_dir).split('\n')
+ ignored_projects = set(['angleproject'])
bugs = set()
for line in lines:
line = line.strip()
@@ -226,12 +227,13 @@ class AutoRoller(object):
if line.startswith(bug_prefix):
bugs_strings = line[len(bug_prefix):].split(',')
for bug_string in bugs_strings:
- try:
- bugs.add(int(bug_string))
- except:
- # skip this, it may be a project specific bug such as
- # "angleproject:X" or an ill-formed BUG= message
- pass
+ ignore_bug = False
+ for ignored_project in ignored_projects:
+ if bug_string.startswith(ignored_project + ':'):
+ ignore_bug = True
+ break
+ if not ignore_bug:
+ bugs.add(bug_string)
return bugs
def _UpdateReadmeFile(self, readme_path, new_revision):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698