Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1910673002: Convert //services from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //services from scoped_ptr to std::unique_ptr BUG=554298 R=ben@chromium.org,jam@chromium.org Committed: https://crrev.com/39fafebd8ff93ca8aac361926e6b3ef840302328 Cr-Commit-Position: refs/heads/master@{#388610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -76 lines) Patch
M services/catalog/catalog.h View 3 chunks +6 lines, -6 lines 0 comments Download
M services/catalog/catalog.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M services/catalog/entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/entry.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M services/catalog/entry_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M services/catalog/instance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/catalog/instance.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/reader.h View 3 chunks +5 lines, -5 lines 0 comments Download
M services/catalog/reader.cc View 8 chunks +14 lines, -12 lines 0 comments Download
M services/catalog/store.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/catalog/types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/public/cpp/tracing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/tracing_app.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/user/user_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/user/user_shell_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/user/user_shell_client.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
Incidentally, should //services have its own OWNERS file?
4 years, 8 months ago (2016-04-20 22:52:01 UTC) #3
jam
lgtm On 2016/04/20 22:52:01, dcheng wrote: > Incidentally, should //services have its own OWNERS file? ...
4 years, 8 months ago (2016-04-20 22:54:44 UTC) #4
jam
On 2016/04/20 22:54:44, jam wrote: > lgtm > > On 2016/04/20 22:52:01, dcheng wrote: > ...
4 years, 8 months ago (2016-04-20 22:55:55 UTC) #5
dcheng
On 2016/04/20 at 22:54:44, jam wrote: > lgtm > > On 2016/04/20 22:52:01, dcheng wrote: ...
4 years, 8 months ago (2016-04-20 22:57:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910673002/1
4 years, 8 months ago (2016-04-20 22:58:03 UTC) #8
Ben Goodger (Google)
lgtm 2
4 years, 8 months ago (2016-04-20 23:12:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:06:36 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39fafebd8ff93ca8aac361926e6b3ef840302328
Cr-Commit-Position: refs/heads/master@{#388610}

Powered by Google App Engine
This is Rietveld 408576698