Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: services/user/user_shell_client.cc

Issue 1910673002: Convert //services from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/user/user_shell_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/user/user_shell_client.h" 5 #include "services/user/user_shell_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h"
8 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
9 #include "components/filesystem/lock_table.h" 10 #include "components/filesystem/lock_table.h"
10 #include "components/leveldb/leveldb_service_impl.h" 11 #include "components/leveldb/leveldb_service_impl.h"
11 #include "mojo/public/cpp/bindings/callback.h" 12 #include "mojo/public/cpp/bindings/callback.h"
12 #include "services/shell/public/cpp/connection.h" 13 #include "services/shell/public/cpp/connection.h"
13 #include "services/user/user_id_map.h" 14 #include "services/user/user_id_map.h"
14 #include "services/user/user_service.h" 15 #include "services/user/user_service.h"
15 16
16 namespace user_service { 17 namespace user_service {
17 18
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 leveldb::LevelDBServiceRequest request) { 57 leveldb::LevelDBServiceRequest request) {
57 if (!leveldb_service_) 58 if (!leveldb_service_)
58 leveldb_service_.reset(new leveldb::LevelDBServiceImpl(task_runner_)); 59 leveldb_service_.reset(new leveldb::LevelDBServiceImpl(task_runner_));
59 leveldb_bindings_.AddBinding(leveldb_service_.get(), std::move(request)); 60 leveldb_bindings_.AddBinding(leveldb_service_.get(), std::move(request));
60 } 61 }
61 62
62 private: 63 private:
63 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 64 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
64 65
65 // Variables that are only accessible on the |leveldb_service_runner_| thread. 66 // Variables that are only accessible on the |leveldb_service_runner_| thread.
66 scoped_ptr<leveldb::LevelDBService> leveldb_service_; 67 std::unique_ptr<leveldb::LevelDBService> leveldb_service_;
67 mojo::BindingSet<leveldb::LevelDBService> leveldb_bindings_; 68 mojo::BindingSet<leveldb::LevelDBService> leveldb_bindings_;
68 69
69 DISALLOW_COPY_AND_ASSIGN(LevelDBServiceObjects); 70 DISALLOW_COPY_AND_ASSIGN(LevelDBServiceObjects);
70 }; 71 };
71 72
72 scoped_ptr<shell::ShellClient> CreateUserShellClient( 73 std::unique_ptr<shell::ShellClient> CreateUserShellClient(
73 scoped_refptr<base::SingleThreadTaskRunner> user_service_runner, 74 scoped_refptr<base::SingleThreadTaskRunner> user_service_runner,
74 scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner) { 75 scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner) {
75 return make_scoped_ptr(new UserShellClient(std::move(user_service_runner), 76 return base::WrapUnique(new UserShellClient(
76 std::move(leveldb_service_runner))); 77 std::move(user_service_runner), std::move(leveldb_service_runner)));
77 } 78 }
78 79
79 UserShellClient::UserShellClient( 80 UserShellClient::UserShellClient(
80 scoped_refptr<base::SingleThreadTaskRunner> user_service_runner, 81 scoped_refptr<base::SingleThreadTaskRunner> user_service_runner,
81 scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner) 82 scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner)
82 : user_service_runner_(std::move(user_service_runner)), 83 : user_service_runner_(std::move(user_service_runner)),
83 leveldb_service_runner_(std::move(leveldb_service_runner)) {} 84 leveldb_service_runner_(std::move(leveldb_service_runner)) {}
84 85
85 UserShellClient::~UserShellClient() { 86 UserShellClient::~UserShellClient() {
86 user_service_runner_->DeleteSoon(FROM_HERE, user_objects_.release()); 87 user_service_runner_->DeleteSoon(FROM_HERE, user_objects_.release());
(...skipping 29 matching lines...) Expand all
116 leveldb::LevelDBServiceRequest request) { 117 leveldb::LevelDBServiceRequest request) {
117 leveldb_service_runner_->PostTask( 118 leveldb_service_runner_->PostTask(
118 FROM_HERE, 119 FROM_HERE,
119 base::Bind( 120 base::Bind(
120 &UserShellClient::LevelDBServiceObjects::OnLevelDBServiceRequest, 121 &UserShellClient::LevelDBServiceObjects::OnLevelDBServiceRequest,
121 leveldb_objects_->AsWeakPtr(), connection, 122 leveldb_objects_->AsWeakPtr(), connection,
122 base::Passed(&request))); 123 base::Passed(&request)));
123 } 124 }
124 125
125 } // namespace user_service 126 } // namespace user_service
OLDNEW
« no previous file with comments | « services/user/user_shell_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698