Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910593004: Plumbs new SpdyFramerVisitorInterface method handling through QUIC test (Closed)

Created:
4 years, 8 months ago by Ryan Hamilton
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@119562680
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumbs new SpdyFramerVisitorInterface method handling through QUIC test utilities, including the test client and test server. Merge internal change: 119568788 BUG=

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -15 lines) Patch
M net/quic/quic_client_session_base.h View 1 chunk +8 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_base.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M net/quic/spdy_utils.h View 1 chunk +8 lines, -1 line 2 comments Download
M net/quic/spdy_utils.cc View 3 chunks +67 lines, -11 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +11 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 2 chunks +10 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +46 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1910483004 Patch 40001

Dependent Patchsets:

Issue 1908723002 Patch 40001

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
4 years, 8 months ago (2016-04-21 19:39:55 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1910593004/diff/50001/net/quic/spdy_utils.h File net/quic/spdy_utils.h (right): https://codereview.chromium.org/1910593004/diff/50001/net/quic/spdy_utils.h#newcode47 net/quic/spdy_utils.h:47: overly nit: extra blank line (not sure if ...
4 years, 8 months ago (2016-04-21 21:00:27 UTC) #3
Ryan Hamilton
thanks! https://codereview.chromium.org/1910593004/diff/50001/net/quic/spdy_utils.h File net/quic/spdy_utils.h (right): https://codereview.chromium.org/1910593004/diff/50001/net/quic/spdy_utils.h#newcode47 net/quic/spdy_utils.h:47: On 2016/04/21 21:00:27, ramant wrote: > overly nit: ...
4 years, 8 months ago (2016-04-21 21:49:55 UTC) #4
ramant (doing other things)
4 years, 8 months ago (2016-04-22 02:01:51 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698