Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1908723002: Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is now just an alias for… (Closed)

Created:
4 years, 8 months ago by Ryan Hamilton
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@119568788
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Migrate references from scoped_ptr to std::unique_ptr. scoped_ptr is now just an alias for unique_ptr, so this is a purely textual change. base/scoped_ptr.h will be removed soon. Merge internal change: 119576588 BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -9 lines) Patch
M net/quic/quic_client_promised_info_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +2 lines, -0 lines 2 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1910593004 Patch 50001

Dependent Patchsets:

Issue 1911653002 Patch 60001

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
4 years, 8 months ago (2016-04-21 19:40:02 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1908723002/diff/40001/net/tools/quic/quic_server.h File net/tools/quic/quic_server.h (right): https://codereview.chromium.org/1908723002/diff/40001/net/tools/quic/quic_server.h#newcode18 net/tools/quic/quic_server.h:18: #include <memory> overly nit: memory was already there.
4 years, 8 months ago (2016-04-21 21:03:30 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/1908723002/diff/40001/net/tools/quic/quic_server.h File net/tools/quic/quic_server.h (right): https://codereview.chromium.org/1908723002/diff/40001/net/tools/quic/quic_server.h#newcode18 net/tools/quic/quic_server.h:18: #include <memory> On 2016/04/21 21:03:30, ramant wrote: > overly ...
4 years, 8 months ago (2016-04-21 21:50:26 UTC) #4
ramant (doing other things)
4 years, 8 months ago (2016-04-22 02:02:26 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698