Issue 1910553002: Don't compute hashes in "--build-summary-exclude-informative" mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1910553002: Don't compute hashes in "--build-summary-exclude-informative" mode. (Closed)

Created:
4 years, 8 months ago by Paul Berry

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't compute hashes in "--build-summary-exclude-informative" mode. The hashes were being thrown away anyway; computing them just wastes time. Cuts the runtime of generating an AST-based summary of the analyzer package (with a warm VM) by about 19%. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a8e665eaf5918ef94b21cd33426d7887b935aada

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	pkg/analyzer/lib/src/summary/idl.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	2 chunks	+15 lines, -4 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/build_mode.dart	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 8 months ago (2016-04-20 18:05:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8e665eaf5918ef94b21cd33426d7887b935aada (presubmit successful).