Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: pkg/analyzer_cli/lib/src/build_mode.dart

Issue 1910553002: Don't compute hashes in "--build-summary-exclude-informative" mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/build_mode.dart
diff --git a/pkg/analyzer_cli/lib/src/build_mode.dart b/pkg/analyzer_cli/lib/src/build_mode.dart
index c165dbdb68c624b911c2963084be455d22bf9639..e60ec098ec7f47828fdc7d9ea4a026c72727bf4a 100644
--- a/pkg/analyzer_cli/lib/src/build_mode.dart
+++ b/pkg/analyzer_cli/lib/src/build_mode.dart
@@ -129,7 +129,7 @@ class BuildMode {
Map<Uri, JavaFile> uriToFileMap;
final List<Source> explicitSources = <Source>[];
- PackageBundleAssembler assembler = new PackageBundleAssembler();
+ PackageBundleAssembler assembler;
final Set<Source> processedSources = new Set<Source>();
final Map<Uri, UnlinkedUnit> uriToUnit = <Uri, UnlinkedUnit>{};
@@ -180,6 +180,8 @@ class BuildMode {
}
// Write summary.
+ assembler = new PackageBundleAssembler(
+ excludeHashes: options.buildSummaryExcludeInformative);
if (options.buildSummaryOutput != null) {
if (options.buildSummaryOnlyAst && !options.buildSummaryFallback) {
_serializeAstBasedSummary(explicitSources);
@@ -203,7 +205,6 @@ class BuildMode {
PackageBundleBuilder sdkBundle = assembler.assemble();
if (options.buildSummaryExcludeInformative) {
sdkBundle.flushInformative();
- sdkBundle.unlinkedUnitHashes = null;
}
io.File file = new io.File(options.buildSummaryOutput);
file.writeAsBytesSync(sdkBundle.toBuffer(), mode: io.FileMode.WRITE_ONLY);
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698