Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910473003: Remove invalidated elements from enqueuer and resolution. (Closed)

Created:
4 years, 8 months ago by ahe
Modified:
4 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove invalidated elements from enqueuer and resolution. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/188cb396c073e362a1179996303c9ee7c9b51f7e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also remove element from _resolutionImpactCache. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
Based on the following Dartino patches: https://codereview.chromium.org/1585323005 https://codereview.chromium.org/1436223002 Now trying to land this in master.
4 years, 8 months ago (2016-04-20 15:50:26 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1910473003/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1910473003/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1983 pkg/compiler/lib/src/compiler.dart:1983: _worldImpactCache.remove(element); Add _resolutionImpactCache.remove(element);
4 years, 8 months ago (2016-04-25 09:39:44 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/1910473003/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1910473003/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1983 pkg/compiler/lib/src/compiler.dart:1983: _worldImpactCache.remove(element); On 2016/04/25 09:39:44, Johnni Winther ...
4 years, 8 months ago (2016-04-26 10:00:46 UTC) #4
ahe
4 years, 8 months ago (2016-04-26 11:18:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
188cb396c073e362a1179996303c9ee7c9b51f7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698