Issue 1585323005: Remove invalidated elements from enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1585323005: Remove invalidated elements from enqueuer. (Closed)

Created:
4 years, 11 months ago by zarah

Modified:
4 years, 11 months ago

Reviewers:
ahe

CC:
fletch+reviews_googlegroups.com

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove invalidated elements from enqueuer. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/d4e8946f9b7c6f3b87655563e0a1999857ad03a3

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/enqueue.dart	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

lgtm https://codereview.chromium.org/1585323005/diff/1/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1585323005/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode1005 pkg/compiler/lib/src/enqueue.dart:1005: void removeFromSet(Map<String, Set<Element>> map, Element element) { It's ...

4 years, 11 months ago (2016-01-18 06:33:05 UTC) #3

zarah

4 years, 11 months ago (2016-01-18 08:35:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d4e8946f9b7c6f3b87655563e0a1999857ad03a3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages